Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/reanimated-clang-tidy-lint-nightly.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Reanimated clang-tidy lint [Nightly]
on:
pull_request:
paths:
- .github/workflows/reanimated-clang-tidy-lint-nightly.yml
schedule:
- cron: '37 19 * * *'

jobs:
reanimated-clang-tidy-lint-nightly:
if: github.repository == 'software-mansion/react-native-reanimated'
uses: ./.github/workflows/reanimated-clang-tidy-lint.yml
31 changes: 31 additions & 0 deletions .github/workflows/reanimated-clang-tidy-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Reanimated clang-tidy lint
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
push:
paths:
- '.github/workflows/reanimated-clang-tidy-lint.yml'
pull_request:
paths:
- '.github/workflows/reanimated-clang-tidy-lint.yml'
workflow_call:
workflow_dispatch:

jobs:
reanimated-clang-tidy-lint:
if: github.repository == 'software-mansion/react-native-reanimated'
env:
REANIMATED_DIR: packages/react-native-reanimated
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install monorepo node dependencies
run: yarn install --immutable
- name: Build Reanimated package
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn build

- name: Run clang-tidy lint
working-directory: ${{ env.REANIMATED_DIR }}
run: yarn lint:clang-tidy
39 changes: 39 additions & 0 deletions packages/react-native-reanimated/.clang-tidy
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
Checks:
# - bugprone-*
# - clang-analyzer-*
# - concurrency-*
- cppcoreguidelines-*
- -cppcoreguidelines-avoid-const-or-ref-data-members
- -cppcoreguidelines-special-member-functions
- -cppcoreguidelines-explicit-virtual-functions
- -cppcoreguidelines-use-default-member-init
- -cppcoreguidelines-non-private-member-variables-in-classes
- -cppcoreguidelines-pro-type-vararg
- -cppcoreguidelines-narrowing-conversions
- -cppcoreguidelines-pro-type-member-init
- -cppcoreguidelines-pro-type-union-access
- -cppcoreguidelines-missing-std-forward
- -cppcoreguidelines-avoid-c-arrays
- -cppcoreguidelines-noexcept-move-operations
- -cppcoreguidelines-prefer-member-initializer
- -cppcoreguidelines-virtual-class-destructor
- -cppcoreguidelines-avoid-magic-numbers
- -cppcoreguidelines-pro-bounds-pointer-arithmetic
- -cppcoreguidelines-macro-usage
- -cppcoreguidelines-no-malloc
- -cppcoreguidelines-rvalue-reference-param-not-moved
- -cppcoreguidelines-pro-type-static-cast-downcast
- -cppcoreguidelines-pro-type-reinterpret-cast
- -cppcoreguidelines-pro-bounds-constant-array-index
- -cppcoreguidelines-init-variables
- -cppcoreguidelines-pro-bounds-array-to-pointer-decay
# - google-*
# - hicpp-*
# - llvm-*
# - misc-*
# - modernize-*
# - objc-*
# - performance-*
# - portability-*
# - readability-*
WarningsAsErrors: "*"
1 change: 1 addition & 0 deletions packages/react-native-reanimated/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"lint:plugin": "cd plugin && yarn lint",
"lint:android": "./scripts/validate-android.sh && ./android/gradlew -p android spotlessCheck -q && ./scripts/cpplint.sh android/src && yarn format:android:cpp --dry-run -Werror && yarn lint:cmake",
"lint:common": "./scripts/validate-common.sh && ./scripts/cpplint.sh Common && yarn format:common --dry-run -Werror",
"lint:clang-tidy": "find Common -iname \"*.h\" -o -iname \"*.cpp\" | xargs ./scripts/clang-tidy-lint.sh",
"lint:apple": "./scripts/validate-apple.sh && yarn format:apple --dry-run -Werror",
"lint:cmake": "find ./android -type d \\( -name build -o -name .cxx \\) -prune -o -type f -name 'CMakeLists.txt' -print | xargs ./scripts/lint-cmake.sh",
"format": "yarn format:js && yarn format:plugin && yarn format:apple && yarn format:android:java && yarn format:android:cpp && yarn format:android:cmake && yarn format:common",
Expand Down
18 changes: 18 additions & 0 deletions packages/react-native-reanimated/scripts/clang-tidy-lint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/bash

if ! which clang-tidy >/dev/null; then
echo "error: clang-tidy not installed, download \
from https://clang.llvm.org/extra/clang-tidy/" 1>&2
exit 1
fi

if [ ! -f "../../compile_commands.json" ]; then
echo "info: missing compile_commands.json, generating one"
(
cd ../../apps/fabric-example || exit 1
yarn
cd android && ./gradlew assembleDebug --build-cache -PreactNativeArchitectures=arm64-v8a
)
fi

clang-tidy --quiet "$@"