Assert that workletsModuleProxy is found#6780
Merged
Conversation
piaskowyk
approved these changes
Dec 2, 2024
tjzel
approved these changes
Dec 3, 2024
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary The following crash happened to me during an app reload. The top stack frame points to `getValueUnpackerCode` but the actual offender is inside `createReanimatedModuleBridgeless` where `workletsModuleProxy` returned from `[workletsModule getWorkletsModuleProxy]` is `nullptr`. <img width="1624" alt="Screenshot 2024-12-02 at 12 59 30" src="https://github.com/user-attachments/assets/a15b8a16-00a9-42aa-abca-4bb03c264986"> ## Test plan
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary The following crash happened to me during an app reload. The top stack frame points to `getValueUnpackerCode` but the actual offender is inside `createReanimatedModuleBridgeless` where `workletsModuleProxy` returned from `[workletsModule getWorkletsModuleProxy]` is `nullptr`. <img width="1624" alt="Screenshot 2024-12-02 at 12 59 30" src="https://github.com/user-attachments/assets/a15b8a16-00a9-42aa-abca-4bb03c264986"> ## Test plan
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary The following crash happened to me during an app reload. The top stack frame points to `getValueUnpackerCode` but the actual offender is inside `createReanimatedModuleBridgeless` where `workletsModuleProxy` returned from `[workletsModule getWorkletsModuleProxy]` is `nullptr`. <img width="1624" alt="Screenshot 2024-12-02 at 12 59 30" src="https://github.com/user-attachments/assets/a15b8a16-00a9-42aa-abca-4bb03c264986"> ## Test plan
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary The following crash happened to me during an app reload. The top stack frame points to `getValueUnpackerCode` but the actual offender is inside `createReanimatedModuleBridgeless` where `workletsModuleProxy` returned from `[workletsModule getWorkletsModuleProxy]` is `nullptr`. <img width="1624" alt="Screenshot 2024-12-02 at 12 59 30" src="https://github.com/user-attachments/assets/a15b8a16-00a9-42aa-abca-4bb03c264986"> ## Test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following crash happened to me during an app reload. The top stack frame points to
getValueUnpackerCodebut the actual offender is insidecreateReanimatedModuleBridgelesswhereworkletsModuleProxyreturned from[workletsModule getWorkletsModuleProxy]isnullptr.Test plan