Skip to content

fix: brownfield integration #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WoLewicki merged 3 commits into from
Dec 4, 2024
Merged

fix: brownfield integration #6774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09c63c
fix: brownfield integration
WoLewicki Nov 29, 2024
7a31c9a
Merge branch 'main' into @wolewicki/handle-browfield
WoLewicki Dec 4, 2024
f9f2bf9
fix: indent
WoLewicki Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/react-native-reanimated/apple/reanimated/apple/Fabric/REAInitializerRCTFabricSurface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

@interface REAInitializerRCTFabricSurface : RCTFabricSurface

@property REAModule *reaModule;
@property __weak REAModule *reaModule;

@end

Expand Down
7 changes: 4 additions & 3 deletions packages/react-native-reanimated/apple/reanimated/apple/REAModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,10 @@ - (void)setBridge:(RCTBridge *)bridge

- (void)setReaSurfacePresenter
{
if (reaSurface == nil) {
// we need only one instance because SurfacePresenter is the same during the application lifetime
reaSurface = [[REAInitializerRCTFabricSurface alloc] init];
if (_surfacePresenter && ![_surfacePresenter surfaceForRootTag:reaSurface.rootTag]) {
if (!reaSurface) {
reaSurface = [[REAInitializerRCTFabricSurface alloc] init];
}
[_surfacePresenter registerSurface:reaSurface];
}
reaSurface.reaModule = self;
Expand Down