Skip to content

refactor(Worklets): Move shareable creation to Worklets#6576

Merged
tjzel merged 2 commits intomainfrom
@tjzel/worklets/move-shareables-to-worklets
Nov 22, 2024
Merged

refactor(Worklets): Move shareable creation to Worklets#6576
tjzel merged 2 commits intomainfrom
@tjzel/worklets/move-shareables-to-worklets

Conversation

@tjzel
Copy link
Collaborator

@tjzel tjzel commented Oct 5, 2024

Summary

Moving makeShareableClone function from NativeReanimatedModule to NativeWorkletsModule.

Test plan

CI

@tjzel tjzel changed the base branch from main to @tjzel/worklets/native-worklets-module-stub October 5, 2024 15:53
@tjzel tjzel marked this pull request as ready for review November 12, 2024 14:39
@tjzel tjzel added the Check compatibility Trigger a time-consuming compatibility check action label Nov 12, 2024
Base automatically changed from @tjzel/worklets/native-worklets-module-stub to main November 19, 2024 14:10
@tjzel tjzel force-pushed the @tjzel/worklets/move-shareables-to-worklets branch from 87fd1fd to e5c4818 Compare November 21, 2024 10:58
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the rest of code 🫡

@tjzel tjzel added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 7c27f5d Nov 22, 2024
@tjzel tjzel deleted the @tjzel/worklets/move-shareables-to-worklets branch November 22, 2024 12:55
tjzel added a commit that referenced this pull request Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Moving `makeShareableClone` function from `NativeReanimatedModule` to
`NativeWorkletsModule`.

## Test plan

CI
tjzel added a commit that referenced this pull request Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Moving `makeShareableClone` function from `NativeReanimatedModule` to
`NativeWorkletsModule`.

## Test plan

CI
tjzel added a commit that referenced this pull request Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Moving `makeShareableClone` function from `NativeReanimatedModule` to
`NativeWorkletsModule`.

## Test plan

CI
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
…sion#6576)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Moving `makeShareableClone` function from `NativeReanimatedModule` to
`NativeWorkletsModule`.

## Test plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check compatibility Trigger a time-consuming compatibility check action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants