chore: Add separate tsconfig for metro-config#6487
Merged
Conversation
MatiPl01
approved these changes
Sep 5, 2024
Member
MatiPl01
left a comment
MatiPl01
left a comment
There was a problem hiding this comment.
I wouldn't say that it suggests that there should be a separate directory in the built library as the react-native-builder-bob field in the package.json specifies which directories should be included in the build process.
To me, adding metro-config directory to the include array in the tsconfig just says that the same typescript configuration should be used for this directory as for the src.
It makes no difference to me which approach we decide to use, so if you prefer this implementation, let's merge this PR.
tomekzaw
approved these changes
Sep 6, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Including both `src` and `metro-config` in `tsconfig.json` of Reanimated package sometimes falsely suggests TypeScript that there should be `lib/module/src` and `lib/module/metro-config` directories. ## Test plan 🚀
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Currently .js files weren't type checked. This PR adds type-checking for them alongside with necessary JSDoc comments. Requires: - software-mansion#6486 - software-mansion#6487 - software-mansion#6485 ## Test plan 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Including both
srcandmetro-configintsconfig.jsonof Reanimated package sometimes falsely suggests TypeScript that there should belib/module/srcandlib/module/metro-configdirectories.Test plan
🚀