Properly stringify tiny color values #6153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the interpolated color values in really tiny, we might emit a string like "rgba(0, 0, 0, 1e-11)". This is not valid syntax, and can cause worklet crashes. Use a regexp to truncate these values to 0.
swansontec
added a commit
to EdgeApp/edge-react-gui
that referenced
this pull request
Jun 21, 2024
6 tasks
swansontec
added a commit
to EdgeApp/edge-react-gui
that referenced
this pull request
Jun 21, 2024
swansontec
added a commit
to EdgeApp/edge-react-gui
that referenced
this pull request
Jun 22, 2024
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->
## Summary
If the interpolated alpha value is really tiny, the code might emit a
string like "rgba(0, 0, 0, 1e-11)". This is not valid syntax, and can
cause worklet crashes. Replace these small values with 0.
## Test plan
This PR includes the necessary unit-test update:
```ts
it('handles tiny values', () => {
const colors = ['#00000000', '#ff802001'];
// We don't want output like "rgba(4, 2, 0, 3.921568627450981e-7)":
const interpolatedColor = interpolateColor(0.0001, [0, 1], colors);
expect(interpolatedColor).toBe(`rgba(4, 2, 0, 0)`);
});
```
---------
Co-authored-by: Krzysztof Piaskowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the interpolated alpha value is really tiny, the code might emit a string like "rgba(0, 0, 0, 1e-11)". This is not valid syntax, and can cause worklet crashes. Replace these small values with 0.
Test plan
This PR includes the necessary unit-test update: