Tests of withDelay
#6150
Merged
Tests of withDelay
#6150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Jun 24, 2024
apps/common-app/src/examples/RuntimeTests/RuntimeTestsExample.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/keepSnapshot.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/keepSnapshot.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/keepSnapshot.test.tsx
Show resolved
Hide resolved
szydlovsky
approved these changes
Jun 25, 2024
Contributor
szydlovsky
left a comment
szydlovsky
left a comment
There was a problem hiding this comment.
Some small NIT but apart from that seems like a solid suite
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests of
withDelayconsist may look a bit complicated, because they contain a bit more logic than other tests. It's because I want to make very peculiar snapshot tests that verify, ifwithDelaymodifier really keeps the same animation.So I compare snapshots of animations with and withoutDelay, and they should be the same (except for some static animation at the beginning).
This way it should be very quick easy to add more tests if we spot and fix some specific bug related to this animation modifier.
One test case is commented out, as it doesn't pass - we have more than one frame of unexpeced delay when using withDelay animation modifier.
Test plan