Skip to content

docs: Move ExampleVideo to MDXComponents#6145

Merged
patrycjakalinska merged 2 commits intomainfrom
@patrycjakalinska/move-ExampleVideo
Jul 1, 2024
Merged

docs: Move ExampleVideo to MDXComponents#6145
patrycjakalinska merged 2 commits intomainfrom
@patrycjakalinska/move-ExampleVideo

Conversation

@patrycjakalinska
Copy link
Contributor

Because ExampleVideo started to be widely used in documentations mdx, we moved it to MDXComponents.js to use it without further imports.

@patrycjakalinska patrycjakalinska marked this pull request as ready for review June 20, 2024 11:37
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it (both dev and production builds) and it seems to work fine. 👍

Additionally, I noticed that you don't need to import CollapsibleCode because it has already been exported in MDXComponents.js.

@patrycjakalinska patrycjakalinska added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 4c4ec47 Jul 1, 2024
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/move-ExampleVideo branch July 1, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants