Fix web exiting animation in StrictMode#6129
Merged
Conversation
m-bert
requested changes
Jun 18, 2024
Contributor
m-bert
left a comment
There was a problem hiding this comment.
Actually, there's one more thing that I need to investigate
m-bert
approved these changes
Jun 18, 2024
48 tasks
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary This PR aims to fixing the web exiting animation when StrictMode is enabled. With StrictMode triggering an additional simulated unmount, our listeners detected the need for an exiting animation. The problem originated from setting `visibility = 'hidden'` on the original component, which remained present, and creating a copy for animation. As a result, the original component was hidden from view in the DOM tree. The solution proposed is simply to eliminate the hiding of components. This adjustment is safe even for scenarios without StrictMode, as the component that is hidden is removed in the same frame, ensuring consistency with the previous behavior. | before | after | | --- | --- | | <video src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/07530231-58e4-429f-bae4-84e876ccc474" /> | <video src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/d4c3324d-74bd-4c3a-9c34-29207268ac95" /> | ## Test plan <details> <summary>code</summary> ```js import { Button } from 'react-native'; import React, { useEffect, useState } from 'react'; import Animated, { FadeOutRight } from 'react-native-reanimated'; function Component() { useEffect(() => { console.log('Component mounted'); return () => { console.log('Component unmounted'); }; }, []); return ( <Animated.View exiting={FadeOutRight.duration(1000)} style={{width: 100, height: 100, borderWidth: 2, backgroundColor: 'lightblue'}} /> ); } export default function EmptyExample() { const [toggle, setToggle] = useState(true); return ( <React.StrictMode> <> <Button title="Press me" onPress={() => { setToggle(!toggle) console.log('Button pressed'); }} /> {toggle && <Component />} </> </React.StrictMode> ); } ``` </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fixing the web exiting animation when StrictMode is enabled. With StrictMode triggering an additional simulated unmount, our listeners detected the need for an exiting animation. The problem originated from setting
visibility = 'hidden'on the original component, which remained present, and creating a copy for animation. As a result, the original component was hidden from view in the DOM tree. The solution proposed is simply to eliminate the hiding of components. This adjustment is safe even for scenarios without StrictMode, as the component that is hidden is removed in the same frame, ensuring consistency with the previous behavior.Screen.Recording.2024-06-17.at.17.30.07.mov
Screen.Recording.2024-06-17.at.17.29.39.mov
Test plan
code