Skip to content

Fix SET in Expo Go #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piaskowyk merged 1 commit into from
Jun 14, 2024
Merged

Fix SET in Expo Go #6116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native-reanimated/apple/LayoutReanimation/REASharedTransitionManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ @implementation REASharedTransitionManager {
NSMutableSet<REAUIView *> *_reattachedViews;
BOOL _isStackDropped;
BOOL _isAsyncSharedTransitionConfigured;
BOOL _isConfigured;
BOOL _clearScreen;
BOOL _isInteractive;
REAUIView *_disappearingScreen;
Expand All @@ -39,6 +38,14 @@ @implementation REASharedTransitionManager {
different context of execution (self != REASharedTransitionManager)
*/
static REASharedTransitionManager *_sharedTransitionManager;
/*
It needs to be a static field because there is a possibility of instantiating
`REASharedTransitionManager` more than once, such as in Expo Go. Method swizzling
operates at the class level rather than the instance level, so `_isConfigured`
should also be a static field to inform every instance that the swizzling process
has occurred successfully.
*/
static BOOL _isConfigured = NO;

- (instancetype)initWithAnimationsManager:(REAAnimationsManager *)animationManager
{
Expand Down