Skip to content

Fix mistakes in example app #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciekstosio merged 1 commit into from
Jun 10, 2024
Merged

Fix mistakes in example app #6099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/common-app/src/examples/ShareableFreezingExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ export default function FreezingShareables() {
/>
</View>
<View style={styles.textAndButton}>
<Text style={styles.text}>🤫</Text>
<Text style={styles.text}>⚠️</Text>
<Button
title="Modify converted remote function"
onPress={tryModifyConvertedRemoteFunction}
/>
</View>
<View style={styles.textAndButton}>
<Text style={styles.text}>⚠️</Text>
<Text style={styles.text}>🤫</Text>
<Button
title="Modify converted host object"
onPress={tryModifyConvertedHostObject}
Expand Down Expand Up @@ -82,7 +82,7 @@ export default function FreezingShareables() {
function tryModifyConvertedArray() {
const obj = [1, 2, 3];
makeShareableCloneRecursive(obj);
obj[0] = 2; // should warn beacuse it's frozen
obj[0] = 2; // should warn because it's frozen
}

function tryModifyConvertedRemoteFunction() {
Expand Down
1 change: 1 addition & 0 deletions apps/common-app/src/examples/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ export const EXAMPLES: Record<string, Example> = {
icon: '📺',
title: 'Screen transition',
screen: ScreenTransitionExample,
missingOnFabric: true,
},

// Basic examples
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-reanimated/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"barfoo",
"barfoo",
"bfrg",
"bokeh",
"bridgeless",
"chlgm",
"coef",
Expand Down Expand Up @@ -42,6 +43,8 @@
"runtimes",
"overdamped",
"automagically",
"shareables",
"swipeable",
"threejs",
"nomalized"
],
Expand Down