Skip to content

Fix configuring unconfigurable properties #6098

Merged
tjzel merged 1 commit intomainfrom
@tjzel/freeze-fix
Jun 10, 2024
Merged

Fix configuring unconfigurable properties #6098
tjzel merged 1 commit intomainfrom
@tjzel/freeze-fix

Conversation

@tjzel
Copy link
Collaborator

@tjzel tjzel commented Jun 10, 2024

Summary

Fixes #6066. When implementing more meaningful way of shareable freezing I overlooked the case when some properties would be unconfigurable. This PR fixes this.

Test plan

New button in ShareableFreezing example checks that it doesn't throw anymore.

Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢 :shipit: 🚢 :shipit: 🚢

@tjzel tjzel added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit b49c0de Jun 10, 2024
@tjzel tjzel deleted the @tjzel/freeze-fix branch June 10, 2024 12:26
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
## Summary

Fixes software-mansion#6066. When implementing more meaningful way of shareable freezing
I overlooked the case when some properties would be unconfigurable. This
PR fixes this.

## Test plan

New button in `ShareableFreezing` example checks that it doesn't throw
anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.12.0] TypeError: property is not configurable on useAnimatedStyle hook

2 participants