Fixes of dark-theme and values in docs #6058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrycjakalinska
changed the title
patrycjakalinska
force-pushed
the
@patrycjakalinska/stylistic-fixed-docs
branch
from
19949fe to
2feb5e4
Compare
piaskowyk
reviewed
May 29, 2024
kacperkapusciak
requested changes
May 29, 2024
Member
kacperkapusciak
left a comment
kacperkapusciak
left a comment
There was a problem hiding this comment.
on light mode on landing the dropdown title should be white on light mode
not broken on this PR could be fixed: in examples the background color of titles on the left side is incorrect:
there's a difference in tone both on light and dark mode
piaskowyk
approved these changes
Jun 3, 2024
kacperkapusciak
approved these changes
Jun 3, 2024
Member
kacperkapusciak
left a comment
kacperkapusciak
left a comment
There was a problem hiding this comment.
I found one more visual glitch where material ui inputs are always in dark mode but it can be fixed in another PR
Member
|
don't merge it yet please, let guys release 3.12.0 from main |
Member
|
Okay, let's resolve the conflicts and I think it's ready to merge |
patrycjakalinska
force-pushed
the
@patrycjakalinska/stylistic-fixed-docs
branch
from
f126c00 to
c0ebe58
Compare
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add offset 'margins' so withDecay example would look cleaner
Before:
Screen.Recording.2024-05-29.at.11.00.42.mov
After:
Screen.Recording.2024-05-29.at.11.00.58.mov
Add dark theme to Section List and Bottom Sheet
Before:
After:
Fix
--swm-dropdown-versions-itemcolor on light-themeBefore:
After:
Remove different background on Examples' sidebar
Before:
After: