Add tests of "withSequence" and clean up imports #6050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
changed the title
latekvo
reviewed
Jun 20, 2024
Member
latekvo
left a comment
latekvo
left a comment
There was a problem hiding this comment.
Looks great, just those 2 minor questions.
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Jun 21, 2024
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 24, 2024
latekvo
approved these changes
Jun 24, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tests of withSequence and clean up the import structure of tests
Test plan