Support snapshots of many views #6047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
piaskowyk
reviewed
Jun 17, 2024
apps/common-app/src/examples/RuntimeTests/tests/TestsOfTestingFramework.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/TestsOfTestingFramework.snapshot.ts
Outdated
Show resolved
Hide resolved
...common-app/src/examples/RuntimeTests/tests/layoutAnimations/entering/enteringColors.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/util.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestComponent.ts
Show resolved
Hide resolved
...mmon-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/matchers/snapshotMatchers.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/UpdatesContainer.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/UpdatesContainer.ts
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 17, 2024
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary
Previously recording snapshots of component containing multiple views
were generating array of all the updates in random order.
The new API is as follows:
```
const component = getTestComponent('ComponentRed');
expect(updatesContainer.getUpdates(component)).toMatchSnapshots(Snapshots.component);
```
If you don't specify any component, but snapshot recorded more than one
an error is thrown. Same if you specify a component, but there is only
one recording.
Other changes in this PR include:
* Organise logic of matcher functions:
* Move rawMatchers into separate file
* Move snapshot matchers into separate file
* Clean up error log of snapshot mismatch and format as an array:
<img width="625" alt="Screenshot 2024-06-06 at 16 23 20"
src="https://github.com/software-mansion/react-native-reanimated/assets/56199675/c239e65c-d71a-44af-83cd-c3256da1d51f">
## Test plan
File `Animations.test.tsx` was renamed into
`TestsOfTestingFramework.test.tsx`, include some tests of snapshot
mismatch (and mismatch of callback functions)
Tested on Paper, on IOS and Android. Some of the fixes, created to make
tests work well on Android, were extracted into separate PR
software-mansion#6084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously recording snapshots of component containing multiple views were generating array of all the updates in random order.
The new API is as follows:
If you don't specify any component, but snapshot recorded more than one an error is thrown. Same if you specify a component, but there is only one recording.
Other changes in this PR include:
Test plan
File
Animations.test.tsxwas renamed intoTestsOfTestingFramework.test.tsx, include some tests of snapshot mismatch (and mismatch of callback functions)Tested on Paper, on IOS and Android. Some of the fixes, created to make tests work well on Android, were extracted into separate PR #6084