Remove getJSValue in favor of toJSValue
#6042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
May 25, 2024
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Here's the current implementation of `Shareable::getJSValue`: https://github.com/software-mansion/react-native-reanimated/blob/e661676f2dcb8feaf00bf7b9be29ef9d84c673df/Common/cpp/SharedItems/Shareables.h#L91-L93 This PR removes `getJSValue` in favor of `toJSValue` as well as updates all usages. ## Test plan Just run the Example app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here's the current implementation of
Shareable::getJSValue:react-native-reanimated/Common/cpp/SharedItems/Shareables.h
Lines 91 to 93 in e661676
This PR removes
getJSValuein favor oftoJSValueas well as updates all usages.Test plan
Just run the Example app.