Fix crash when current activity is null #6022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
commented
May 15, 2024
piaskowyk
approved these changes
Jun 3, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
Just one small change and we can merge 🫡
android/src/main/java/com/swmansion/reanimated/keyboard/WindowsInsetsManager.java
Outdated
Show resolved
Hide resolved
…sInsetsManager.java Co-authored-by: Krzysztof Piaskowy <[email protected]>
maciekstosio
deleted the
@maciekstosio/Fix-crash-when-current-activity-is-null
branch
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should fix: #5892. We do not check if the current activity is
nulland it seems that it randomly can be null. It seems like ongoing issue on react native side: facebook/react-native#37518, facebook/react-native#18345. TheuseAnimatedKeyboardhook won't work when the app when current activity isnull, but it should not crash the app anymore. Our assumption is that most of the libs handle it this way (#5892), so it must be some corner case when most functionality won't work - that's why we don't try to recover from this state.