Monorepo [1/?] - move precommit scripts to root #5998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
…sky-and-precommit
…sky-and-precommit
…sky-and-precommit
piaskowyk
approved these changes
Jun 5, 2024
Base automatically changed from
@tjzel/monorepo-github-actions
to
@tjzel/monorepo
June 5, 2024 13:27
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
…code and paper example (#5999) ## Summary ## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5998 ## Summary This particular pull request moves `app` directory to a package called `reanimated-app` and `Example` directory to `reanimated-paper-example` package. It also makes use of hoisted `node_modules` for those two packages and `react-native-reanimated`. ## Test plan Run `reanimated-paper-example` on both iOS and Android to see that it works.
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
…code and paper example (#5999) This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5998 This particular pull request moves `app` directory to a package called `reanimated-app` and `Example` directory to `reanimated-paper-example` package. It also makes use of hoisted `node_modules` for those two packages and `react-native-reanimated`. Run `reanimated-paper-example` on both iOS and Android to see that it works.
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5998 - #5999 - #6008 - #6020 - #6023 - #6029 - #6051 - #6053 ## Summary This particular pull request takes removes `reanimated2` directory from `src`. ## Test plan Example apps should work as expected. --------- Co-authored-by: Krzysztof Piaskowy <[email protected]> Co-authored-by: Michał Bert <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is a part of the effort of migrating to monorepo structure:
Summary
This particular pull requests moves the precommit husky script to the root directory to enable it. It also extracts
lint-stagedconfiguration frompackages/react-native-reanimatedto a separate file for it to be less polluted.Test plan
The script should be working as expected. Try it by cloning the monorepo and doing something bad in the code.