Skip to content

Fix EXC_BAD_ACCESS crash on iOS in [REAAnimationsManager clearSharedTransitionConfigForTag:]#5975

Merged
tomekzaw merged 2 commits intomainfrom
@tomekzaw/fix-set-ios-bad-access
May 5, 2024
Merged

Fix EXC_BAD_ACCESS crash on iOS in [REAAnimationsManager clearSharedTransitionConfigForTag:]#5975
tomekzaw merged 2 commits intomainfrom
@tomekzaw/fix-set-ios-bad-access

Conversation

@tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented May 5, 2024

Summary

Fixes #5947. Fixes #5968.

When react-native-reanimated is installed but not used directly, switching between bottom tabs from @react-navigation/bottom-tabs will result in a EXC_BAD_ACCESS crash on iOS.

This PR adds missing mock for _clearSharedTransitionConfigForTag as suggested by @bartlomiejbloniarz.

Test plan

Try repro from #5947 (comment)

@tomekzaw tomekzaw added this pull request to the merge queue May 5, 2024
Merged via the queue into main with commit cea5dff May 5, 2024
@tomekzaw tomekzaw deleted the @tomekzaw/fix-set-ios-bad-access branch May 5, 2024 13:39
GSTJ referenced this pull request in GSTJ/react-native-magic-modal May 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-reanimated](https://github.com/software-mansion/react-native-reanimated)
| [`~3.10.1` ->
`~3.11.0`](https://renovatebot.com/diffs/npm/react-native-reanimated/3.10.1/3.11.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-reanimated/3.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-reanimated/3.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-reanimated/3.10.1/3.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-reanimated/3.10.1/3.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-reanimated
(react-native-reanimated)</summary>

###
[`v3.11.0`](https://github.com/software-mansion/react-native-reanimated/releases/tag/3.11.0)

[Compare
Source](https://github.com/software-mansion/react-native-reanimated/compare/3.10.1...3.11.0)

#### What's Changed

- Fix EXC_BAD_ACCESS crash on iOS in `[REAAnimationsManager
clearSharedTransitionConfigForTag:]` by
[@&#8203;tomekzaw](https://github.com/tomekzaw) in
[https://github.com/software-mansion/react-native-reanimated/pull/5975](https://github.com/software-mansion/react-native-reanimated/pull/5975)
- Fix uncaught exception 'NSUnknownKeyException' on app reload on iOS by
[@&#8203;tomekzaw](https://github.com/tomekzaw) in
[https://github.com/software-mansion/react-native-reanimated/pull/5976](https://github.com/software-mansion/react-native-reanimated/pull/5976)
- Test two ways to use sharedValue in `useAnimatedStyle` by
[@&#8203;Latropos](https://github.com/Latropos) in
[https://github.com/software-mansion/react-native-reanimated/pull/5893](https://github.com/software-mansion/react-native-reanimated/pull/5893)
- docs: fix grammar by [@&#8203;wodin](https://github.com/wodin) in
[https://github.com/software-mansion/react-native-reanimated/pull/5978](https://github.com/software-mansion/react-native-reanimated/pull/5978)
- fix: build issues on visionOS by
[@&#8203;okwasniewski](https://github.com/okwasniewski) in
[https://github.com/software-mansion/react-native-reanimated/pull/5980](https://github.com/software-mansion/react-native-reanimated/pull/5980)

**Full Changelog**:
software-mansion/react-native-reanimated@3.10.0...3.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/GSTJ/react-native-magic-modal).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants