Skip to content

Remove CellRendererComponent from Animated.FlatList props #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Latropos merged 3 commits into from
May 14, 2024
Merged

Remove CellRendererComponent from Animated.FlatList props #5951

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43b1400
Initial commit
Latropos Apr 29, 2024
4d13209
Better error message
Latropos Apr 29, 2024
970479a
Update src/reanimated2/component/FlatList.tsx
Latropos May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions __typetests__/common/AnimatedComponentTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ function AnimatedComponentPropsTest() {
<MyAnimatedView style={RNStyle} />
<Animated.ScrollView style={RNStyle} />
<MyAnimatedScrollView style={RNStyle} />
<Animated.FlatList
style={RNStyle}
// @ts-expect-error
CellRendererComponent={() => {
return <View />;
}}
data={[]}
renderItem={() => <View />}
/>
<Animated.FlatList
style={RNStyle}
data={[]}
Expand Down
4 changes: 4 additions & 0 deletions src/reanimated2/component/FlatList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ interface ReanimatedFlatListPropsWithLayout<T>
* Lets you skip entering and exiting animations of FlatList items when on FlatList mount or unmount.
*/
skipEnteringExitingAnimations?: boolean;
/**
* CellRendererComponent is not supported in Animated.FlatList
Comment thread
Latropos marked this conversation as resolved.
Outdated
*/
CellRendererComponent?: never;
}

export type FlatListPropsWithLayout<T> = ReanimatedFlatListPropsWithLayout<T>;
Expand Down