fix: copy state in reanimated commit hook#5934
Merged
Conversation
50 tasks
piaskowyk
approved these changes
Apr 25, 2024
Member
|
Just wondering if we should also add explicit state here? |
tomekzaw
requested changes
Apr 25, 2024
Member
tomekzaw
left a comment
tomekzaw
left a comment
There was a problem hiding this comment.
I think we should pass state explicitly there as well
Member
Author
|
Done |
piaskowyk
pushed a commit
that referenced
this pull request
Apr 26, 2024
## Summary Fix for the issue: Expensify/App#40048 which root cause of seems to be the not copied state of `ScrollView` when this code is not added. I'll try to provide a simple repro when I get some time to do it. ## Test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for the issue: Expensify/App#40048 which root cause of seems to be the not copied state of
ScrollViewwhen this code is not added. I'll try to provide a simple repro when I get some time to do it.Test plan