Fix layout animations that use custom animations changing colours #5903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As stated in #5826, layout animation that had a custom animation inside (specifically,
withDelaythat launched awithTimingthat animates background colour change) just wasn't properly working. Turned out, that we have to pass values between colour animations as unprocessed rgba's rather than processed numbers.This PR fixes it and, of course, the issue as well.
Test plan
You can try the following code (it is a cleaned version of snack given in the mentioned issue):
Code