Use one constructor for NativeReanimatedModule with bridgeless #5868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Apr 4, 2024
Member
There was a problem hiding this comment.
@tjzel Thanks again for your effort.
General feedback: Why don't we just instantiate JSScheduler before calling NativeReanimatedModule ctor? This way we can avoid adding JSScheduleDependencyHolder to our codebase class at all.
The only obstacle is that we need to pass rnRuntime along with jsInvoker (in bridgeful mode) but this is not a real problem as we luckily have access to it without any problem. In bridgeless mode, we don't need rnRuntime at all.
Base automatically changed from
@wolewicki/bridgeless-mode-with-runtime-executor
to
main
April 5, 2024 10:39
tjzel
force-pushed
the
@tjzel/unify-constructor
branch
from
cadeab5 to
659d5e9
Compare
tomekzaw
reviewed
Apr 5, 2024
tomekzaw
requested changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@tomekzaw wanted this badly
Test plan