Fix web useScrollViewOffset on wrapped scrolls#5861
Merged
szydlovsky merged 3 commits intomainfrom Apr 3, 2024
Merged
Conversation
tjzel
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #5790, it seems like scrolls can be wrapped in other views (by for example setting their
onRefreshproperty), which makes refs to them point to the wrapping view, not them. Thus I add support for such situations to theuseScrollViewOffsethook, which is our only hook that needs to access the component itself.Test plan
Testing code