Skip to content

Screen Transition update public API#5833

Merged
piaskowyk merged 1 commit intomainfrom
@piaskowyk/screen-transition-update-public-api
Mar 26, 2024
Merged

Screen Transition update public API#5833
piaskowyk merged 1 commit intomainfrom
@piaskowyk/screen-transition-update-public-api

Conversation

@piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Mar 25, 2024

Summary

This PR updates public API for custom gesture based screen transition. It renames field topScreenFrame to topScreenStyle.

This PR was requested by developer experience department as Software Mansion. cc @kacperkapusciak 🫡

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm didnt test

@piaskowyk
Copy link
Member Author

I tested it in rnscreens Example app and it works 🎉

@piaskowyk piaskowyk added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 80bcfd8 Mar 26, 2024
@piaskowyk piaskowyk deleted the @piaskowyk/screen-transition-update-public-api branch March 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants