Make /app good for for 0.74 #5830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Mar 25, 2024
piaskowyk
approved these changes
Mar 26, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
For me is legit 🫡 Before merging:
- Let's sort out the CI - https://github.com/software-mansion/react-native-reanimated/actions/runs/8421856626/job/23059739159?pr=5830
- Wait for approval on #5815, and then let's merge both pull requests together to keep the main branch in a consistent state.
Merged
tomekzaw
requested changes
Mar 26, 2024
tomekzaw
approved these changes
Mar 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Summary This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order: - #5830 - #5815 - #5834 - #5734 ## Test plan :shipit: --------- Co-authored-by: Wojciech Lewicki <[email protected]> Co-authored-by: Krzysztof Piaskowy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Summary This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order: - #5830 - #5815 - #5834 - #5734 ## Test plan :shipit: --------- Co-authored-by: Wojciech Lewicki <[email protected]> Co-authored-by: Krzysztof Piaskowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order:
Test plan