Update useScrollViewOffset docs #5824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
requested changes
Mar 24, 2024
kacperkapusciak
approved these changes
Mar 25, 2024
Member
kacperkapusciak
left a comment
kacperkapusciak
left a comment
There was a problem hiding this comment.
i'm approving in advance but please address all the comments
patrycjakalinska
approved these changes
Mar 25, 2024
Contributor
patrycjakalinska
left a comment
patrycjakalinska
left a comment
There was a problem hiding this comment.
my concerns were already addressed by Kacper -> self-closing tag and variable naming conventions, also approving in advance
tjzel
approved these changes
Mar 25, 2024
tjzel
approved these changes
Mar 25, 2024
szydlovsky
deleted the
@szydlovsky/useScrollViewOffset-docs-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useScrollViewOffsethook got a web support, so I bumped REA in docs and changed the example to showcase its features more strikingly.Screen.Recording.2024-03-21.at.15.10.25.mov
Test plan
Open docs page for
useScrollViewOffset.