Implement not for runtime tests
#5813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Mar 25, 2024
app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/Matchers.ts
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Mar 25, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
Almost done 👏 I think this is the last review iteration
app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/Matchers.ts
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Mar 26, 2024
app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/Matchers.ts
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add possibility to negate some of the matchers. I've decided that there is no need to negate snapshot matchers, so I've handled just the other functions. Both API and implementation are inspired with jest tests.
Test plan
All runtime tests work