Add information about type of toValue to our documentation
#5806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kacperkapusciak Do we want to copy-paste it three times or is there a possibility to move it into a separate file that will be included in each section with |
szydlovsky
approved these changes
Mar 19, 2024
kacperkapusciak
requested changes
Mar 19, 2024
Member
|
it is possible to reuse the text by using components like we do in RNGH https://github.com/software-mansion/react-native-gesture-handler/blob/main/docs/docs/gestures/fling-gesture.md?plain=1#L82 but copying and pasting it 3 times is more than fine. If i were you I'd copy'n'paste it 3 times |
Co-authored-by: Kacper Kapuściak <[email protected]>
kacperkapusciak
approved these changes
Mar 20, 2024
added 2 commits
March 22, 2024 11:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our documentation is missing information about type of
toValueNote
The information added in this PR should be included in our documentation 3 times, on pages
withTiming,withSpringandwithDecay. I will copy-paste it once the text is accepted