Merged
Conversation
piaskowyk
approved these changes
Mar 15, 2024
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Mar 15, 2024
## Summary Currently we don't reexport jest specific function (especially `setUpTests`) in our mock. This is due to fact that our recommended way of initializing Reanimated for testing is to do that in `jest-setup.js` file. However, doing it just before the test suite (with `beforeAll` jest function) is just as good, if even not better considering test separation. This cannot be done if Reanimated is already mocked. ## Test plan Add Reanimated to a new RN app, mock Reanimated and see that `setUpTests` cannot be used in `beforeAll`. Do it using Reanimated built from this PR and see that it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we don't reexport jest specific function (especially
setUpTests) in our mock. This is due to fact that our recommended way of initializing Reanimated for testing is to do that injest-setup.jsfile.However, doing it just before the test suite (with
beforeAlljest function) is just as good, if even not better considering test separation. This cannot be done if Reanimated is already mocked.Test plan
Add Reanimated to a new RN app, mock Reanimated and see that
setUpTestscannot be used inbeforeAll. Do it using Reanimated built from this PR and see that it works.