fix: remove top level is_fabric check #5779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Mar 12, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
Can we be certain that on the very first call to one of those functions, isFabric() will return the correct value?
Member
Author
|
@piaskowyk I don't think so, I am not fully aware when those checks are used and if they are used before this line: is evaluated then it will not work. I think it is still better than having it in top-level scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR removing top level check for
isFabricsince it should be evaluated after it is added toglobalwhich may not be done at that point.Test plan