Make "Reanimated" title in docs interactive. #5766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- selected portion of the title is now movable via the visible interaction boxes - commiting before I rewrite this system with different approach
…t affected. Committing before reworking dragging mechanism and adding visual improvements.
Co-authored-by: Krzysztof Piaskowy <[email protected]>
Code cleanup.
Code cleanup.
…o look before this PR. After turning on isInteractive flag, it becomes interactive.
Member
Author
|
As per @piaskowyk request, by default this website is drawn as it used to be, and interactivity is added to it separately only after the initial non-interactive part has been loaded. |
latekvo
changed the title
Fixed structure and styling.
piaskowyk
reviewed
Mar 14, 2024
Removed unnecessary useEffect. Fixed styles.
Increased readability.
Add better typing annotations. Fix pixel alignment issues.
Member
Author
|
I noticed that mobile view is not aligned with how it used to look, so there is one more commit coming. |
… @latekvo/docs/make-title-movable
… @latekvo/docs/make-title-movable
piaskowyk
reviewed
Mar 18, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
I think this is the last review iteration 🎉
Add dependencies to useEffect.
… @latekvo/docs/make-title-movable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the "Reanimated" title in docs interactive.
Test plan
To test this feature,
docsfolderyarn startResults
Screen.Recording.2024-03-07.at.15.48.28.mov