Make makeShareableCloneRecursive more readable#5724
Merged
Conversation
bartlomiejbloniarz
requested changes
Nov 19, 2024
piaskowyk
reviewed
Nov 22, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
Did you run the RuntimeTests against those changes?
piaskowyk
approved these changes
Nov 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## Summary This PR restores the `nativeStateSource` argument in `makeShareableCloneRecursive` calls, that got lost in #5724 ## Test plan
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Refactoring `makeShareableCloneRecursive` so it would be actually readable now. The behavior of the function (and it's flow) shouldn't change. ## Test plan - [x] Runtime tests
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary This PR restores the `nativeStateSource` argument in `makeShareableCloneRecursive` calls, that got lost in #5724 ## Test plan
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Refactoring `makeShareableCloneRecursive` so it would be actually readable now. The behavior of the function (and it's flow) shouldn't change. ## Test plan - [x] Runtime tests
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary This PR restores the `nativeStateSource` argument in `makeShareableCloneRecursive` calls, that got lost in #5724 ## Test plan
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary Refactoring `makeShareableCloneRecursive` so it would be actually readable now. The behavior of the function (and it's flow) shouldn't change. ## Test plan - [x] Runtime tests
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary This PR restores the `nativeStateSource` argument in `makeShareableCloneRecursive` calls, that got lost in #5724 ## Test plan
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Refactoring `makeShareableCloneRecursive` so it would be actually readable now. The behavior of the function (and it's flow) shouldn't change. ## Test plan - [x] Runtime tests
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
…e-mansion#6763) ## Summary This PR restores the `nativeStateSource` argument in `makeShareableCloneRecursive` calls, that got lost in software-mansion#5724 ## Test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring
makeShareableCloneRecursiveso it would be actually readable now.The behavior of the function (and it's flow) shouldn't change.
Test plan