Delete removed methods from ReanimatedUIManager #5723
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since RN 0.74.0-rc.0, methods
replaceExistingNonRootViewandremoveSubviewsFromContainerWithIDhave been removed from UIManagerModule. This means that they cannot be also used in ReanimatedUIManager anymore. Even more, apps that are using Reanimated cannot be built on Android, because of the error about undeclared symbols. Since I couldn't find any places where these methods were executed, I've decided to remove them.Test plan
I believe that checking if examples from Example app work properly should be sufficient.