Skip to content

Conversation

@tboba
Copy link
Contributor

@tboba tboba commented Feb 23, 2024

Summary

Since RN 0.74.0-rc.0, methods replaceExistingNonRootView and removeSubviewsFromContainerWithID have been removed from UIManagerModule. This means that they cannot be also used in ReanimatedUIManager anymore. Even more, apps that are using Reanimated cannot be built on Android, because of the error about undeclared symbols. Since I couldn't find any places where these methods were executed, I've decided to remove them.

Test plan

I believe that checking if examples from Example app work properly should be sufficient.

Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! Could you check if it Layout Animation works for older react native version too? (0.72, 0.73) Best way to do this is to build a Reanimated package and test it in fresh RN app.

@tboba
Copy link
Contributor Author

tboba commented Feb 23, 2024

@piaskowyk I just tested layout animations on Example app (which has react-native version 3.7.1 installed) and created a fresh RN app with 0.72 with HabitsExample and I can't find any issues there!

@tomekzaw
Copy link
Member

tomekzaw commented Mar 4, 2024

This will be fixed in #5734 which also introduces a new sourceset for RN 0.74+.

@piaskowyk
Copy link
Member

This will be fixed in #5734 which also introduces a new sourceset for RN 0.74+.

But thanks for the PR 😊

@piaskowyk piaskowyk closed this Mar 7, 2024
@tboba tboba deleted the @tboba/fix-rn74 branch March 7, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants