-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Better error when passing easing from 'react-native' instead of 'reanimated' #5639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
9c4e836
Add a good error log
6b52e25
Refactor
bf2343c
Fix
6d544f4
Merge branch 'main' into acynk/no-rn-easing
949854d
Fix
700a96d
Update src/reanimated2/animation/timing.ts
Latropos 7ffbf34
Improve message
cc9cb92
Add dev
db8da1f
Add comment
bf35466
Self review
db734de
Better error format
21ec0d6
Update src/reanimated2/animation/timing.ts
Latropos 97951df
Merge branch 'main' into acynk/no-rn-easing
5ab4919
Code review
e978800
Merge branch 'main' into acynk/no-rn-easing
b552873
Skip checks on web
5d952e9
Merge branch 'main' into acynk/no-rn-easing
1b2ed19
Reneme 'isWorklet' into 'isWorkletFunction'
9664833
Apply suggestions from code review
Latropos cbe0a2c
fix
8ca3364
Remove 'bind' check
8124a3a
Improve formatting
762e012
Merge branch 'main' into acynk/no-rn-easing
b2fa1eb
Code review
0518206
Don't verify easing in keyframe
e4756c9
Get rid of function name in error \n and improve
433c93a
revert changes to EmptyExample.tsx
70c1fbc
Move checks on JS
e521d4e
Merge branch 'main' into acynk/no-rn-easing
83a083d
Update src/reanimated2/commonTypes.ts
Latropos 52a3538
code review
00ac6fb
refactor
1597003
Merge branch 'main' into acynk/no-rn-easing
4c298a5
Add worklet check
959ef09
Update src/reanimated2/animation/util.ts
Latropos a2c60a0
Update src/reanimated2/animation/timing.ts
Latropos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.