Skip to content

Conversation

@Latropos
Copy link
Contributor

@Latropos Latropos commented Jan 17, 2024

Summary

I was able to do this changes automatically, and then I've reviewed them to be sure nothing was broken.

This PR should me merged after eslint update: #5594

Test plan

Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this atomic and quite necessary PR. Well done!

@Latropos Latropos marked this pull request as ready for review January 25, 2024 12:18
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callback: callback I will miss you 😭

@tomekzaw
Copy link
Member

tomekzaw commented Feb 1, 2024

I believe this PR is ready to be merged, what are we waiting for?

@tjzel
Copy link
Collaborator

tjzel commented Feb 2, 2024

@tomekzaw

This PR should me merged after eslint update: #5594

github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2024
## Summary
* We were using @typescript-eslint/X in version 5.x, but we should use
6.x
* Now we can use type-checked rules:
  * I've turned some of them off:
    * '@typescript-eslint/no-unsafe-call': 'off',
    * '@typescript-eslint/no-unsafe-member-access': 'off',
    * '@typescript-eslint/no-unsafe-return': 'off',
    * '@typescript-eslint/no-unsafe-assignment': 'off',
    * '@typescript-eslint/no-unsafe-argument': 'off',
  * fixed the others:
    * Don't use objects in string literals
* Fix shorthand in
#5595
* I didn't turn type-checked rules for plugin. It would require fixing
the configuration, but our eslint configuration should be migrated to
new format anyway.
* In the future I want to migrate `eslintrc` config files and to turn
object shorthand on
 
## Test plan

---------

Co-authored-by: Aleksandra Cynk <aleksandracynk@Aleksandras-MacBook-Pro-3.local>
Base automatically changed from acynk/eslint-update to main February 2, 2024 11:57
@Latropos Latropos added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit bcfa13a Feb 2, 2024
@Latropos Latropos deleted the acynk/apply-shorthand branch February 2, 2024 12:13
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2025
Bumps [axios](https://github.com/axios/axios) from 1.8.4 to 1.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.12.0</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li>adding build artifacts (<a
href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd">9ec86de</a>)</li>
<li>dont add dist on release (<a
href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11">a2edc36</a>)</li>
<li><strong>fetch-adapter:</strong> set correct Content-Type for Node
FormData (<a
href="https://github.com/axios/axios/issues/6998">#6998</a>)
(<a
href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d">a9f47af</a>)</li>
<li><strong>node:</strong> enforce maxContentLength for data: URLs (<a
href="https://github.com/axios/axios/issues/7011">#7011</a>)
(<a
href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593">945435f</a>)</li>
<li>package exports (<a
href="https://github.com/axios/axios/issues/5627">#5627</a>)
(<a
href="https://github.com/axios/axios/commit/aa78ac23fc9036163308c0f6bd2bb885e7af3f36">aa78ac2</a>)</li>
<li><strong>params:</strong> removing '[' and ']' from URL encode
exclude characters (<a
href="https://github.com/axios/axios/issues/3316">#3316</a>)
(<a
href="https://github.com/axios/axios/issues/5715">#5715</a>)
(<a
href="https://github.com/axios/axios/commit/6d84189349c43b1dcdd977b522610660cc4c7042">6d84189</a>)</li>
<li>release pr run (<a
href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2">fd7f404</a>)</li>
<li><strong>types:</strong> change the type guard on isCancel (<a
href="https://github.com/axios/axios/issues/5595">#5595</a>)
(<a
href="https://github.com/axios/axios/commit/0dbb7fd4f61dc568498cd13a681fa7f907d6ec7e">0dbb7fd</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>adapter:</strong> surface low‑level network error details;
attach original error via cause (<a
href="https://github.com/axios/axios/issues/6982">#6982</a>)
(<a
href="https://github.com/axios/axios/commit/78b290c57c978ed2ab420b90d97350231c9e5d74">78b290c</a>)</li>
<li><strong>fetch:</strong> add fetch, Request, Response env config
variables for the adapter; (<a
href="https://github.com/axios/axios/issues/7003">#7003</a>)
(<a
href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b">c959ff2</a>)</li>
<li>support reviver on JSON.parse (<a
href="https://github.com/axios/axios/issues/5926">#5926</a>)
(<a
href="https://github.com/axios/axios/commit/2a9763426e43d996fd60d01afe63fa6e1f5b4fca">2a97634</a>),
closes <a
href="https://github.com/axios/axios/issues/5924">#5924</a></li>
<li><strong>types:</strong> extend AxiosResponse interface to include
custom headers type (<a
href="https://github.com/axios/axios/issues/6782">#6782</a>)
(<a
href="https://github.com/axios/axios/commit/7960d34eded2de66ffd30b4687f8da0e46c4903e">7960d34</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li> <a href="https://github.com/WillianAgostini" title="+132/-16760
([#7002](axios/axios#7002)
[#5926](axios/axios#5926)
[#6782](axios/axios#6782) )">Willian
Agostini</a></li>
<li> <a href="https://github.com/DigitalBrainJS" title="+4263/-293
([#7006](axios/axios#7006)
[#7003](axios/axios#7003) )">Dmitriy
Mozgovoy</a></li>
<li> <a href="https://github.com/mkhani01" title="+111/-15
([#6982](axios/axios#6982) )">khani</a></li>
<li> <a href="https://github.com/AmeerAssadi" title="+123/-0
([#7011](axios/axios#7011) )">Ameer
Assadi</a></li>
<li> <a href="https://github.com/emiedonmokumo" title="+55/-35
([#6998](axios/axios#6998) )">Emiedonmokumo
Dick-Boro</a></li>
<li> <a href="https://github.com/opsysdebug" title="+8/-8
([#6980](axios/axios#6980) )">Zeroday
BYTE</a></li>
<li> <a href="https://github.com/jasonsaayman" title="+7/-7
([#6985](axios/axios#6985)
[#6985](axios/axios#6985) )">Jason
Saayman</a></li>
<li> <a href="https://github.com/HealGaren" title="+5/-7
([#5715](axios/axios#5715) )">최예찬</a></li>
<li> <a href="https://github.com/gligorkot" title="+3/-1
([#5627](axios/axios#5627) )">Gligor
Kotushevski</a></li>
<li> <a href="https://github.com/adimit" title="+2/-1
([#5595](axios/axios#5595) )">Aleksandar
Dimitrov</a></li>
</ul>
<h2>Release v1.11.0</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li>form-data npm pakcage (<a
href="https://github.com/axios/axios/issues/6970">#6970</a>)
(<a
href="https://github.com/axios/axios/commit/e72c193722530db538b19e5ddaaa4544d226b253">e72c193</a>)</li>
<li>prevent RangeError when using large Buffers (<a
href="https://github.com/axios/axios/issues/6961">#6961</a>)
(<a
href="https://github.com/axios/axios/commit/a2214ca1bc60540baf2c80573cea3a0ff91ba9d1">a2214ca</a>)</li>
<li><strong>types:</strong> resolve type discrepancies between ESM and
CJS TypeScript declaration files (<a
href="https://github.com/axios/axios/issues/6956">#6956</a>)
(<a
href="https://github.com/axios/axios/commit/8517aa16f8d082fc1d5309c642220fa736159110">8517aa1</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li> <a href="https://github.com/izzygld" title="+186/-93
([#6970](axios/axios#6970) )">izzy
goldman</a></li>
<li> <a href="https://github.com/manishsahanidev" title="+70/-0
([#6961](axios/axios#6961) )">Manish
Sahani</a></li>
<li> <a href="https://github.com/noritaka1166" title="+12/-10
([#6938](axios/axios#6938)
[#6939](axios/axios#6939) )">Noritaka
Kobayashi</a></li>
<li> <a href="https://github.com/jrnail23" title="+13/-2
([#6956](axios/axios#6956) )">James
Nail</a></li>
<li> <a href="https://github.com/Tejaswi1305" title="+1/-1
([#6894](axios/axios#6894)
)">Tejaswi1305</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h1><a
href="https://github.com/axios/axios/compare/v1.11.0...v1.12.0">1.12.0</a>
(2025-09-11)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>adding build artifacts (<a
href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd">9ec86de</a>)</li>
<li>dont add dist on release (<a
href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11">a2edc36</a>)</li>
<li><strong>fetch-adapter:</strong> set correct Content-Type for Node
FormData (<a
href="https://github.com/axios/axios/issues/6998">#6998</a>)
(<a
href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d">a9f47af</a>)</li>
<li><strong>node:</strong> enforce maxContentLength for data: URLs (<a
href="https://github.com/axios/axios/issues/7011">#7011</a>)
(<a
href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593">945435f</a>)</li>
<li>package exports (<a
href="https://github.com/axios/axios/issues/5627">#5627</a>)
(<a
href="https://github.com/axios/axios/commit/aa78ac23fc9036163308c0f6bd2bb885e7af3f36">aa78ac2</a>)</li>
<li><strong>params:</strong> removing '[' and ']' from URL encode
exclude characters (<a
href="https://github.com/axios/axios/issues/3316">#3316</a>)
(<a
href="https://github.com/axios/axios/issues/5715">#5715</a>)
(<a
href="https://github.com/axios/axios/commit/6d84189349c43b1dcdd977b522610660cc4c7042">6d84189</a>)</li>
<li>release pr run (<a
href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2">fd7f404</a>)</li>
<li><strong>types:</strong> change the type guard on isCancel (<a
href="https://github.com/axios/axios/issues/5595">#5595</a>)
(<a
href="https://github.com/axios/axios/commit/0dbb7fd4f61dc568498cd13a681fa7f907d6ec7e">0dbb7fd</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>adapter:</strong> surface low‑level network error details;
attach original error via cause (<a
href="https://github.com/axios/axios/issues/6982">#6982</a>)
(<a
href="https://github.com/axios/axios/commit/78b290c57c978ed2ab420b90d97350231c9e5d74">78b290c</a>)</li>
<li><strong>fetch:</strong> add fetch, Request, Response env config
variables for the adapter; (<a
href="https://github.com/axios/axios/issues/7003">#7003</a>)
(<a
href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b">c959ff2</a>)</li>
<li>support reviver on JSON.parse (<a
href="https://github.com/axios/axios/issues/5926">#5926</a>)
(<a
href="https://github.com/axios/axios/commit/2a9763426e43d996fd60d01afe63fa6e1f5b4fca">2a97634</a>),
closes <a
href="https://github.com/axios/axios/issues/5924">#5924</a></li>
<li><strong>types:</strong> extend AxiosResponse interface to include
custom headers type (<a
href="https://github.com/axios/axios/issues/6782">#6782</a>)
(<a
href="https://github.com/axios/axios/commit/7960d34eded2de66ffd30b4687f8da0e46c4903e">7960d34</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li> <a href="https://github.com/WillianAgostini" title="+132/-16760
([#7002](axios/axios#7002)
[#5926](axios/axios#5926)
[#6782](axios/axios#6782) )">Willian
Agostini</a></li>
<li> <a href="https://github.com/DigitalBrainJS" title="+4263/-293
([#7006](axios/axios#7006)
[#7003](axios/axios#7003) )">Dmitriy
Mozgovoy</a></li>
<li> <a href="https://github.com/mkhani01" title="+111/-15
([#6982](axios/axios#6982) )">khani</a></li>
<li> <a href="https://github.com/AmeerAssadi" title="+123/-0
([#7011](axios/axios#7011) )">Ameer
Assadi</a></li>
<li> <a href="https://github.com/emiedonmokumo" title="+55/-35
([#6998](axios/axios#6998) )">Emiedonmokumo
Dick-Boro</a></li>
<li> <a href="https://github.com/opsysdebug" title="+8/-8
([#6980](axios/axios#6980) )">Zeroday
BYTE</a></li>
<li> <a href="https://github.com/jasonsaayman" title="+7/-7
([#6985](axios/axios#6985)
[#6985](axios/axios#6985) )">Jason
Saayman</a></li>
<li> <a href="https://github.com/HealGaren" title="+5/-7
([#5715](axios/axios#5715) )">최예찬</a></li>
<li> <a href="https://github.com/gligorkot" title="+3/-1
([#5627](axios/axios#5627) )">Gligor
Kotushevski</a></li>
<li> <a href="https://github.com/adimit" title="+2/-1
([#5595](axios/axios#5595) )">Aleksandar
Dimitrov</a></li>
</ul>
<h1><a
href="https://github.com/axios/axios/compare/v1.10.0...v1.11.0">1.11.0</a>
(2025-07-22)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>form-data npm pakcage (<a
href="https://github.com/axios/axios/issues/6970">#6970</a>)
(<a
href="https://github.com/axios/axios/commit/e72c193722530db538b19e5ddaaa4544d226b253">e72c193</a>)</li>
<li>prevent RangeError when using large Buffers (<a
href="https://github.com/axios/axios/issues/6961">#6961</a>)
(<a
href="https://github.com/axios/axios/commit/a2214ca1bc60540baf2c80573cea3a0ff91ba9d1">a2214ca</a>)</li>
<li><strong>types:</strong> resolve type discrepancies between ESM and
CJS TypeScript declaration files (<a
href="https://github.com/axios/axios/issues/6956">#6956</a>)
(<a
href="https://github.com/axios/axios/commit/8517aa16f8d082fc1d5309c642220fa736159110">8517aa1</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li> <a href="https://github.com/izzygld" title="+186/-93
([#6970](axios/axios#6970) )">izzy
goldman</a></li>
<li> <a href="https://github.com/manishsahanidev" title="+70/-0
([#6961](axios/axios#6961) )">Manish
Sahani</a></li>
<li> <a href="https://github.com/noritaka1166" title="+12/-10
([#6938](axios/axios#6938)
[#6939](axios/axios#6939) )">Noritaka
Kobayashi</a></li>
<li> <a href="https://github.com/jrnail23" title="+13/-2
([#6956](axios/axios#6956) )">James
Nail</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/0d8ad6e1de0f5339e02bc262d6f0df4936974120"><code>0d8ad6e</code></a>
chore(release): v1.12.0 (<a
href="https://github.com/axios/axios/issues/7013">#7013</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2"><code>fd7f404</code></a>
fix: release pr run</li>
<li><a
href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11"><code>a2edc36</code></a>
fix: dont add dist on release</li>
<li><a
href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd"><code>9ec86de</code></a>
fix: adding build artifacts</li>
<li><a
href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593"><code>945435f</code></a>
fix(node): enforce maxContentLength for data: URLs (<a
href="https://github.com/axios/axios/issues/7011">#7011</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/28e5e3016d6ed0b3ec489427e4ec00133f45ddc2"><code>28e5e30</code></a>
chore(sponsor): update sponsor block (<a
href="https://github.com/axios/axios/issues/7005">#7005</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/d03f245a40ec016b190748a865cce9fe3815c903"><code>d03f245</code></a>
chore(CI): fixed release info script to use npm registry instead of git
as fi...</li>
<li><a
href="https://github.com/axios/axios/commit/a0bc91137950f36a1f6b0a2a60d11fd7f245ff0e"><code>a0bc911</code></a>
chore: removing dist files from src (<a
href="https://github.com/axios/axios/issues/7002">#7002</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b"><code>c959ff2</code></a>
feat(fetch): add fetch, Request, Response env config variables for the
adapte...</li>
<li><a
href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d"><code>a9f47af</code></a>
fix(fetch-adapter): set correct Content-Type for Node FormData (<a
href="https://github.com/axios/axios/issues/6998">#6998</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/axios/axios/compare/v1.8.4...v1.12.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.8.4&new-version=1.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/software-mansion/react-native-reanimated/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants