Allow SETs configuration to be updated on rerender #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
@bartlomiejbloniarz/modify-layout-animations
to
main
January 15, 2024 09:50
bartlomiejbloniarz
force-pushed
the
@bartlomiejbloniarz/modify-sets
branch
from
b54c2da to
f3debe0
Compare
tomekzaw
reviewed
Mar 12, 2024
...c/main/java/com/swmansion/reanimated/layoutReanimation/ReanimatedNativeHierarchyManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the current SETs implementation to allow for:
Additional changes
In this PR I also changed the logic behind applying transforms to views in Snapshots on iOS. Now during the transition (so when the shared element is removed from it's parent) we apply a transform to the shared element, that is a combination of all the transforms that were applied by superviews before removing this element from its parent. I decided to do this in this PR, since those changes were closely tied to other changes I was already making in the iOS Snapshot logic. I, however, decided to not apply analogous changes on Android in this PR, because due to the API differences, the logic there would be too complicated, making this already humongous PR too big/dense.
TODO:
isInteractiveissuesTest plan
Check the behavior of
[SET] Change themeexample (and possibly all the other SET examples). Also on iOS check the[SET] Nested transformsexample.