Hold weak reference only #3157

piaskowyk · 2022-04-08T13:42:27Z

Description

We held in the _viewForTag registry strong references for views even without exiting animation. When an object hasn't had exiting animation they weren't removed from this registry. In effect, the object was unmounted from the tree of views but still was in memory.

Fixes #3124

Test

code

import Animated, {
  FadeIn,
  FadeOut
} from 'react-native-reanimated';
import { View, Button } from 'react-native';
import React, { useState } from 'react';

const style = {
  width: 100, height: 50, backgroundColor: 'black', margin: 10
}
export default function MountingUnmountingTest() {
  const [toogle, setToggle] = useState(false);

  return (
    <View
      style={{
        flex: 1,
        flexDirection: 'column',
        marginTop: 60
      }}>
      <Button title="toggle" onPress={() => setToggle(!toogle)} />
      { 
        toogle && 
        <Animated.View 
          entering={FadeIn}
          exiting={FadeOut}
          style={style} 
        /> 
      }
      { 
        toogle && 
        <View>
          <Animated.View 
            entering={FadeIn}
            exiting={FadeOut}
            style={style} 
          /> 
        </View>
      }
      { 
        toogle && 
        <Animated.View
          entering={FadeIn}
          exiting={FadeOut}
        >
          <Animated.View
            style={style} 
          /> 
        </Animated.View>
      }
      { 
        toogle && 
        <Animated.View
          entering={FadeIn}
          exiting={FadeOut}
        >
          <Animated.View 
            entering={FadeIn}
            exiting={FadeOut}
            style={style} 
          /> 
        </Animated.View>
      }
      { 
        toogle && 
        <Animated.View
          entering={FadeIn}
          exiting={FadeOut.duration(2000)}
        >
          <Animated.View 
            entering={FadeIn}
            exiting={FadeOut}
            style={style} 
          /> 
        </Animated.View>
      }
      { 
        toogle && 
        <Animated.View
          entering={FadeIn}
          exiting={FadeOut}
        >
          <Animated.View 
            entering={FadeIn}
            exiting={FadeOut.duration(2000)}
            style={style} 
          /> 
        </Animated.View>
      }
    </View>
  );
}

hirbod · 2022-04-08T17:13:38Z

@piaskowyk ping me whenever you think this is ready for test if you need my feedback here.

ios/LayoutReanimation/REAAnimationsManager.m

piaskowyk · 2022-04-11T13:36:16Z

@hirbod It's ready for testing, let me know if you have some time to check if it works.

hirbod · 2022-04-11T13:54:10Z

@piaskowyk thanks, I will test this today, EOD

kmagiera · 2022-04-11T14:23:21Z

ios/LayoutReanimation/REAAnimationsManager.m

-    [_viewForTag removeObjectForKey:tag];
-    [_toRemove removeObject:tag];
+    [_viewsToRemove removeObjectForKey:tag];
+    [_viewsWithExitingAnimation removeObjectForKey:tag];


It still seem like there are cases where views can be kept in those dicts. Specifically, it appears like the only codepath that leads to the removal is when the given view is returned from findRoot. But findRoot can in some cases return the parent of a given view and not the view itself. It'd feel safer if we have a cleaner contract as to when given view needs to be removed from an array. Also it'd be good to add a few lines of documentation for each of these two new dicts. I can understand the purpose of viewWithExitingAnimations fine by its name but not so much with viewToRemove – i.e. I don't know why we need to keep track of all views we remove.

As to "a cleaner contract" an example would be to always remove object from viewWithExitingAnimations after animation is finished (have a callback of some sort ?). With viewsToRemove we should ideally have something similar. Now it is very difficult to track the codepath that leads to deletion and it can be altered to easily.

@mateioprea is that maybe your case, when calling reset on navigator, which leaves views mounted even after applying this fix?

yes, in the perf monitor i can see that the total number of rendered view increase over time.
My app's lifecycle is:
Mount 1st screen -> navigate to 2nd screen -> navigate to 3rd screen -> navigate to last screen -> Reset navigation to 1st screen and then start again the same cycle.

Previously I've seen custom UI views not being unmounted but this PR fixes that issue. But i can see an increase of total number of rendered views with each new session.

hirbod · 2022-04-12T17:42:43Z

@piaskowyk I haven't tested the PR yet since there have been requests for changes by @kmagiera, so I will wait until they are sorted out. I got a confirmation though, that it did fix most of the issues for @mateioprea but not all
#3157 (comment)

LeviWilliams · 2022-04-13T14:36:42Z

Any eta of when this could be patched in? Specifically including the changes requested by @kmagiera. Really appreciate all the work here as this is something we're fully blocked by. Thank you!

hirbod · 2022-04-13T14:48:22Z

Any eta of when this could be patched in? Specifically including the changes requested by @kmagiera. Really appreciate all the work here as this is something we're fully blocked by. Thank you!

I am pretty sure soon, since Expo SDK 45 is around the corner.

LeviWilliams · 2022-04-18T14:46:15Z

Forgive me for the bump, @piaskowyk any progress here? Thanks again for all the help

davidskaarup · 2022-04-19T13:49:27Z

Also following this, we had to remove all LayoutAnimation from our project, so would be really cool to get the fix out.

mateioprea · 2022-04-19T13:55:38Z

^^ you can always use patch package to get the fix asap into your project. I did that and it's live since last week :)

LeviWilliams · 2022-04-19T13:59:40Z

@mateioprea I'm still worried with your comment regarding the increased number of rendered views even including this fix, have you not had any issues with this in prod?? We have a lot of navigation resets in our app and increasing the rendered views over time will greatly affect our performance

mateioprea · 2022-04-19T14:01:09Z

Yup, but memory management will release those views eventually. don't worry

AlexanderEggers · 2022-04-22T08:21:59Z

@piaskowyk What is your plan to unblock this PR?

hirbod · 2022-04-25T12:38:15Z

It looks like they've decided to rewrite LayoutAnimation instead:
https://github.com/software-mansion/react-native-reanimated/commits/layoutanim_rewrite

0fa7649

piaskowyk · 2022-04-28T10:11:04Z

I can confirm that we rewriting the layout animation code and this issue will be fixed with these changes.

catalinmiron · 2022-05-03T11:03:17Z

@piaskowyk @kmagiera is the new approach going to support reparenting?

ziyoshams · 2022-05-26T13:46:40Z

Do you guys have an ETA for when this fix will make to the release pipeline?

LeviWilliams · 2022-06-22T21:09:14Z

Are layout animations still being rewritten?

hirbod · 2022-06-23T11:29:57Z

No commits since 4th of May unfortunately

piaskowyk · 2022-06-29T07:36:02Z

I am closing this PR because we decided to rewrite the layout animation, and this issue will be resolve here #3332

hkar19 · 2022-08-02T07:18:49Z

i made this into a patch if anyone seeking:

but it this didn't solve my problem which might be similar to #3286

react-native-reanimated+2.9.1.patch

--- a/node_modules/react-native-reanimated/ios/LayoutReanimation/REAAnimationsManager.m
+++ b/node_modules/react-native-reanimated/ios/LayoutReanimation/REAAnimationsManager.m
@@ -22,8 +22,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   RCTUIManager *_uiManager;
   REAUIManager *_reaUiManager;
   NSMutableDictionary<NSNumber *, NSNumber *> *_states;
-  NSMutableDictionary<NSNumber *, UIView *> *_viewForTag;
-  NSMutableSet<NSNumber *> *_toRemove;
+  NSMutableDictionary<NSNumber *, UIView *> *_viewsToRemove;
+  NSMutableDictionary<NSNumber *, UIView *> *_viewsWithExitingAnimation;
   NSMutableArray<NSString *> *_targetKeys;
   NSMutableArray<NSString *> *_currentKeys;
   BOOL _cleaningScheduled;
@@ -45,8 +45,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
     _uiManager = uiManager;
     _reaUiManager = (REAUIManager *)uiManager;
     _states = [NSMutableDictionary new];
-    _viewForTag = [NSMutableDictionary new];
-    _toRemove = [NSMutableSet new];
+    _viewsToRemove = [NSMutableDictionary new];
+    _viewsWithExitingAnimation = [NSMutableDictionary new];
     _cleaningScheduled = false;
 
     _targetKeys = [NSMutableArray new];
@@ -65,8 +65,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   _removeConfigForTag = nil;
   _uiManager = nil;
   _states = nil;
-  _viewForTag = nil;
-  _toRemove = nil;
+  _viewsToRemove = nil;
+  _viewsWithExitingAnimation = nil;
   _cleaningScheduled = false;
   _targetKeys = nil;
   _currentKeys = nil;
@@ -119,20 +119,20 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   }
 }
 
-- (BOOL)dfs:(UIView *)root view:(UIView *)view cands:(NSMutableSet<NSNumber *> *)cands
+- (BOOL)dfs:(UIView *)root view:(UIView *)view
 {
   NSNumber *tag = view.reactTag;
   if (tag == nil) {
     return true;
   }
-  if (![cands containsObject:tag] && _states[tag] != nil) {
+  if (_viewsToRemove[tag] == nil && _states[tag] != nil) {
     return true;
   }
   BOOL cannotStripe = false;
   NSArray<UIView *> *toRemoveCopy = [view.reactSubviews copy];
   for (UIView *child in toRemoveCopy) {
     if (![view isKindOfClass:[RCTTextView class]]) {
-      cannotStripe |= [self dfs:root view:child cands:cands];
+      cannotStripe |= [self dfs:root view:child];
     }
   }
   if (!cannotStripe) {
@@ -140,26 +140,35 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
       [_reaUiManager unregisterView:view];
     }
     [_states removeObjectForKey:tag];
-    [_viewForTag removeObjectForKey:tag];
-    [_toRemove removeObject:tag];
+    [_viewsToRemove removeObjectForKey:tag];
+    [_viewsWithExitingAnimation removeObjectForKey:tag];
   }
   return cannotStripe;
 }
 
+- (UIView *)findView:(NSNumber *)tag
+{
+  UIView *view = _viewsToRemove[tag];
+  if (view != nil) {
+    return view;
+  }
+  view = [_reaUiManager viewForReactTag:tag];
+  if (view != nil) {
+    return view;
+  }
+  return _viewsWithExitingAnimation[tag];
+}
+
 - (void)removeLeftovers
 {
   NSMutableSet<NSNumber *> *roots = [NSMutableSet new];
-  for (NSNumber *viewTag in _toRemove) {
-    UIView *view = _viewForTag[viewTag];
-    if (view == nil) {
-      view = [_reaUiManager viewForReactTag:viewTag];
-      _viewForTag[viewTag] = view;
-    }
+  for (NSNumber *key in _viewsToRemove) {
+    UIView *view = _viewsToRemove[key];
     [self findRoot:view roots:roots];
   }
   for (NSNumber *viewTag in roots) {
-    UIView *view = _viewForTag[viewTag];
-    [self dfs:view view:view cands:_toRemove];
+    UIView *view = [self findView:viewTag];
+    [self dfs:view view:view];
   }
 }
 
@@ -173,7 +182,10 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
     if (state == Disappearing) {
       _states[tag] = [NSNumber numberWithInt:ToRemove];
       if (tag != nil) {
-        [_toRemove addObject:tag];
+        UIView *view = [self findView:tag];
+        if (view != nil) {
+          [_viewsToRemove setObject:view forKey:tag];
+        }
       }
       [self scheduleCleaning];
     }
@@ -192,7 +204,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
 
   NSMutableDictionary *dataComponenetsByName = [_uiManager valueForKey:@"_componentDataByName"];
   RCTComponentData *componentData = dataComponenetsByName[@"RCTView"];
-  [self setNewProps:[newStyle mutableCopy] forView:_viewForTag[tag] withComponentData:componentData];
+  UIView *view = [self findView:tag];
+  [self setNewProps:[newStyle mutableCopy] forView:view withComponentData:componentData];
 }
 
 - (double)getDoubleOrZero:(NSNumber *)number
@@ -299,12 +312,13 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   if (state == Inactive) {
     if (startValues != nil) {
       _states[tag] = [NSNumber numberWithInt:ToRemove];
-      [_toRemove addObject:tag];
+      [_viewsToRemove setObject:view forKey:tag];
       [self scheduleCleaning];
     }
     return;
   }
   _states[tag] = [NSNumber numberWithInt:Disappearing];
+  [_viewsWithExitingAnimation setObject:view forKey:tag];
   NSDictionary *preparedValues = [self prepareDataForAnimatingWorklet:startValues frameConfig:ExitingFrame];
   _startAnimationForTag(tag, @"exiting", preparedValues, @(0));
 }
@@ -315,7 +329,6 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   NSNumber *tag = view.reactTag;
   if (_states[tag] == nil) {
     _states[tag] = [NSNumber numberWithInt:Inactive];
-    _viewForTag[tag] = view;
   }
   NSMutableDictionary *targetValues = after.values;
   ViewState state = [_states[tag] intValue];

hkar19 · 2022-08-02T09:17:29Z

interestingly, after i combined this #3157 with #3298, i solved my problem which is similar to #3286.

this is my patch: react-native-reanimated+2.9.1.patch

you can use patch-package to apply this patch

--- a/node_modules/react-native-reanimated/ios/LayoutReanimation/REAAnimationsManager.m
+++ b/node_modules/react-native-reanimated/ios/LayoutReanimation/REAAnimationsManager.m
@@ -22,8 +22,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   RCTUIManager *_uiManager;
   REAUIManager *_reaUiManager;
   NSMutableDictionary<NSNumber *, NSNumber *> *_states;
-  NSMutableDictionary<NSNumber *, UIView *> *_viewForTag;
-  NSMutableSet<NSNumber *> *_toRemove;
+  NSMutableDictionary<NSNumber *, UIView *> *_viewsToRemove;
+  NSMutableDictionary<NSNumber *, UIView *> *_viewsWithExitingAnimation;
   NSMutableArray<NSString *> *_targetKeys;
   NSMutableArray<NSString *> *_currentKeys;
   BOOL _cleaningScheduled;
@@ -45,8 +45,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
     _uiManager = uiManager;
     _reaUiManager = (REAUIManager *)uiManager;
     _states = [NSMutableDictionary new];
-    _viewForTag = [NSMutableDictionary new];
-    _toRemove = [NSMutableSet new];
+    _viewsToRemove = [NSMutableDictionary new];
+    _viewsWithExitingAnimation = [NSMutableDictionary new];
     _cleaningScheduled = false;
 
     _targetKeys = [NSMutableArray new];
@@ -65,8 +65,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   _removeConfigForTag = nil;
   _uiManager = nil;
   _states = nil;
-  _viewForTag = nil;
-  _toRemove = nil;
+  _viewsToRemove = nil;
+  _viewsWithExitingAnimation = nil;
   _cleaningScheduled = false;
   _targetKeys = nil;
   _currentKeys = nil;
@@ -119,20 +119,20 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   }
 }
 
-- (BOOL)dfs:(UIView *)root view:(UIView *)view cands:(NSMutableSet<NSNumber *> *)cands
+- (BOOL)dfs:(UIView *)root view:(UIView *)view
 {
   NSNumber *tag = view.reactTag;
   if (tag == nil) {
     return true;
   }
-  if (![cands containsObject:tag] && _states[tag] != nil) {
+  if (_viewsToRemove[tag] == nil && _states[tag] != nil) {
     return true;
   }
   BOOL cannotStripe = false;
   NSArray<UIView *> *toRemoveCopy = [view.reactSubviews copy];
   for (UIView *child in toRemoveCopy) {
     if (![view isKindOfClass:[RCTTextView class]]) {
-      cannotStripe |= [self dfs:root view:child cands:cands];
+      cannotStripe |= [self dfs:root view:child];
     }
   }
   if (!cannotStripe) {
@@ -140,26 +140,35 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
       [_reaUiManager unregisterView:view];
     }
     [_states removeObjectForKey:tag];
-    [_viewForTag removeObjectForKey:tag];
-    [_toRemove removeObject:tag];
+    [_viewsToRemove removeObjectForKey:tag];
+    [_viewsWithExitingAnimation removeObjectForKey:tag];
   }
   return cannotStripe;
 }
 
+- (UIView *)findView:(NSNumber *)tag
+{
+  UIView *view = _viewsToRemove[tag];
+  if (view != nil) {
+    return view;
+  }
+  view = [_reaUiManager viewForReactTag:tag];
+  if (view != nil) {
+    return view;
+  }
+  return _viewsWithExitingAnimation[tag];
+}
+
 - (void)removeLeftovers
 {
   NSMutableSet<NSNumber *> *roots = [NSMutableSet new];
-  for (NSNumber *viewTag in _toRemove) {
-    UIView *view = _viewForTag[viewTag];
-    if (view == nil) {
-      view = [_reaUiManager viewForReactTag:viewTag];
-      _viewForTag[viewTag] = view;
-    }
+  for (NSNumber *key in _viewsToRemove) {
+    UIView *view = _viewsToRemove[key];
     [self findRoot:view roots:roots];
   }
   for (NSNumber *viewTag in roots) {
-    UIView *view = _viewForTag[viewTag];
-    [self dfs:view view:view cands:_toRemove];
+    UIView *view = [self findView:viewTag];
+    [self dfs:view view:view];
   }
 }
 
@@ -173,7 +182,10 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
     if (state == Disappearing) {
       _states[tag] = [NSNumber numberWithInt:ToRemove];
       if (tag != nil) {
-        [_toRemove addObject:tag];
+        UIView *view = [self findView:tag];
+        if (view != nil) {
+          [_viewsToRemove setObject:view forKey:tag];
+        }
       }
       [self scheduleCleaning];
     }
@@ -192,7 +204,8 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
 
   NSMutableDictionary *dataComponenetsByName = [_uiManager valueForKey:@"_componentDataByName"];
   RCTComponentData *componentData = dataComponenetsByName[@"RCTView"];
-  [self setNewProps:[newStyle mutableCopy] forView:_viewForTag[tag] withComponentData:componentData];
+  UIView *view = [self findView:tag];
+  [self setNewProps:[newStyle mutableCopy] forView:view withComponentData:componentData];
 }
 
 - (double)getDoubleOrZero:(NSNumber *)number
@@ -299,12 +312,13 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   if (state == Inactive) {
     if (startValues != nil) {
       _states[tag] = [NSNumber numberWithInt:ToRemove];
-      [_toRemove addObject:tag];
+      [_viewsToRemove setObject:view forKey:tag];
       [self scheduleCleaning];
     }
     return;
   }
   _states[tag] = [NSNumber numberWithInt:Disappearing];
+  [_viewsWithExitingAnimation setObject:view forKey:tag];
   NSDictionary *preparedValues = [self prepareDataForAnimatingWorklet:startValues frameConfig:ExitingFrame];
   _startAnimationForTag(tag, @"exiting", preparedValues, @(0));
 }
@@ -315,7 +329,6 @@ typedef NS_ENUM(NSInteger, FrameConfigType) { EnteringFrame, ExitingFrame };
   NSNumber *tag = view.reactTag;
   if (_states[tag] == nil) {
     _states[tag] = [NSNumber numberWithInt:Inactive];
-    _viewForTag[tag] = view;
   }
   NSMutableDictionary *targetValues = after.values;
   ViewState state = [_states[tag] intValue];
diff --git a/node_modules/react-native-reanimated/ios/LayoutReanimation/REAUIManager.mm b/node_modules/react-native-reanimated/ios/LayoutReanimation/REAUIManager.mm
index 16ed327..2695d7d 100644
--- a/node_modules/react-native-reanimated/ios/LayoutReanimation/REAUIManager.mm
+++ b/node_modules/react-native-reanimated/ios/LayoutReanimation/REAUIManager.mm
@@ -117,6 +117,11 @@ std::weak_ptr<reanimated::Scheduler> _scheduler;
   // Reanimated changes /start
   if (isUIViewRegistry) {
     NSMutableDictionary<NSNumber *, id<RCTComponent>> *viewRegistry = [self valueForKey:@"_viewRegistry"];
+      NSMutableDictionary<NSNumber *, NSMutableSet<id<RCTComponent>> *> *toBeRemovedRegisterCopy =
+              [NSMutableDictionary dictionaryWithDictionary:_toBeRemovedRegister];
+          for (NSNumber *key in _toBeRemovedRegister) {
+            toBeRemovedRegisterCopy[key] = [NSMutableSet setWithSet:_toBeRemovedRegister[key]];
+          }
     for (id<RCTComponent> toRemoveChild in _toBeRemovedRegister[containerTag]) {
       NSInteger lastIndex = [container reactSubviews].count - 1;
       if (lastIndex < 0) {
@@ -129,7 +134,7 @@ std::weak_ptr<reanimated::Scheduler> _scheduler;
       ) {
         // we don't want layout animations when removing modals or Screens of native-stack since it brings buggy
         // behavior
-        [_toBeRemovedRegister[container.reactTag] removeObject:toRemoveChild];
+        [toBeRemovedRegisterCopy[container.reactTag] removeObject:toRemoveChild];
         [permanentlyRemovedChildren removeObject:toRemoveChild];
 
       } else {
@@ -137,6 +142,7 @@ std::weak_ptr<reanimated::Scheduler> _scheduler;
         viewRegistry[toRemoveChild.reactTag] = toRemoveChild;
       }
     }
+      _toBeRemovedRegister = toBeRemovedRegisterCopy;
       
     for (UIView *removedChild in permanentlyRemovedChildren) {
       [self callAnimationForTree:removedChild parentTag:containerTag];

Hold weak refference only

b246fa9

Save only exitin

a2acad6

piaskowyk self-assigned this Apr 9, 2022

Exiting animation registry

e8391f8

piaskowyk requested a review from tomekzaw April 11, 2022 10:28

piaskowyk marked this pull request as ready for review April 11, 2022 10:39

piaskowyk requested a review from kmagiera April 11, 2022 11:01

tomekzaw requested changes Apr 11, 2022

View reviewed changes

ios/LayoutReanimation/REAAnimationsManager.m Outdated Show resolved Hide resolved

ios/LayoutReanimation/REAAnimationsManager.m Outdated Show resolved Hide resolved

Improvements after review

fc47ffe

tomekzaw approved these changes Apr 11, 2022

View reviewed changes

kmagiera reviewed Apr 11, 2022

View reviewed changes

annasychugina mentioned this pull request May 25, 2022

🐛 Unmounting the Camera component does not turn off the torch mrousavy/react-native-vision-camera#1032

Closed

4 tasks

piaskowyk closed this Jun 29, 2022

hirbod mentioned this pull request Oct 31, 2022

Use a weak map for storing view references #3687

Closed

piaskowyk deleted the @piaskowyk/hold-weak-refference-only branch April 3, 2023 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hold weak reference only #3157

Hold weak reference only #3157

piaskowyk commented Apr 8, 2022 •

edited

Loading

hirbod commented Apr 8, 2022 •

edited

Loading

piaskowyk commented Apr 11, 2022

hirbod commented Apr 11, 2022

kmagiera Apr 11, 2022

hirbod Apr 11, 2022 •

edited

Loading

mateioprea Apr 11, 2022

hirbod commented Apr 12, 2022

LeviWilliams commented Apr 13, 2022

hirbod commented Apr 13, 2022

LeviWilliams commented Apr 18, 2022

davidskaarup commented Apr 19, 2022

mateioprea commented Apr 19, 2022

LeviWilliams commented Apr 19, 2022

mateioprea commented Apr 19, 2022

AlexanderEggers commented Apr 22, 2022

hirbod commented Apr 25, 2022 •

edited

Loading

piaskowyk commented Apr 28, 2022

catalinmiron commented May 3, 2022

ziyoshams commented May 26, 2022

LeviWilliams commented Jun 22, 2022

hirbod commented Jun 23, 2022

piaskowyk commented Jun 29, 2022

hkar19 commented Aug 2, 2022 •

edited

Loading

hkar19 commented Aug 2, 2022

Hold weak reference only #3157

Hold weak reference only #3157

Conversation

piaskowyk commented Apr 8, 2022 • edited Loading

Description

Test

hirbod commented Apr 8, 2022 • edited Loading

piaskowyk commented Apr 11, 2022

hirbod commented Apr 11, 2022

kmagiera Apr 11, 2022

Choose a reason for hiding this comment

hirbod Apr 11, 2022 • edited Loading

Choose a reason for hiding this comment

mateioprea Apr 11, 2022

Choose a reason for hiding this comment

hirbod commented Apr 12, 2022

LeviWilliams commented Apr 13, 2022

hirbod commented Apr 13, 2022

LeviWilliams commented Apr 18, 2022

davidskaarup commented Apr 19, 2022

mateioprea commented Apr 19, 2022

LeviWilliams commented Apr 19, 2022

mateioprea commented Apr 19, 2022

AlexanderEggers commented Apr 22, 2022

hirbod commented Apr 25, 2022 • edited Loading

piaskowyk commented Apr 28, 2022

catalinmiron commented May 3, 2022

ziyoshams commented May 26, 2022

LeviWilliams commented Jun 22, 2022

hirbod commented Jun 23, 2022

piaskowyk commented Jun 29, 2022

hkar19 commented Aug 2, 2022 • edited Loading

hkar19 commented Aug 2, 2022

piaskowyk commented Apr 8, 2022 •

edited

Loading

hirbod commented Apr 8, 2022 •

edited

Loading

hirbod Apr 11, 2022 •

edited

Loading

hirbod commented Apr 25, 2022 •

edited

Loading

hkar19 commented Aug 2, 2022 •

edited

Loading