Merged
Conversation
6 tasks
Contributor
Author
|
@piaskowyk i've tested the auto install and it works really great. we don't need the expo adapter anymore and also reduce issues coming from the tricky gradle setup. please help to review when you get a chance. thanks! |
7 tasks
Member
|
Glad to hear it! 😀 Thanks for your changes! |
piaskowyk
approved these changes
Apr 1, 2022
Contributor
Author
|
thanks @piaskowyk to land this pr 🚀 |
Kudo
added a commit
to expo/expo
that referenced
this pull request
Apr 2, 2022
# Why targeting react-native 0.68 in sdk 45 even though it's rc now. # How - [x] upgrade package.json - [x] migrate bare-expo - [x] migrate expo-template-bare-minimum - [x] migrate bare-sandbox ❗️ reanimated build error because our previous integration is broken on AGP 7. solution in [the pr](software-mansion/react-native-reanimated#3113). since the pr is not landed yet, i have a [temporarily workaround to patch reanimated](8e5662b). # Test Plan - android bare-expo launch test - ios bare-expo launch test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
with #3005, we don't need the expo adapter to install JSI bindings. by removing the adapter, this pr will also fix #3084 and fix #3021
Changes
remove expo adapter
Test code and steps to reproduce
$ createNPMPackage.shyarn add file:/path/to/react-native-reanimated-2.5.0.tgzand test launching.yarn add file:/path/to/react-native-reanimated-2.5.0.tgzand test launching.Checklist