[Web] Remove workaround for touch events allowing to change state too soon #3794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ordering of touch events on the web was mostly aligned with Android. To unify the ordering across all platforms (along #3793), this PR changes it so that
onTouchesDownis called beforeonBeginandonTouchesMoveis called beforeonUpdate.Another change is enforcing going through
BEGANwhen imperatively changing the state fromUNDETERMINEDtoACTIVE.And a fix for an issue that came out due to the above changes - when the discrete gestures were imperatively activated inside
onTouchesDown, the order was:This was because those gestures transition to the
ENDstate immediately afterACTIVE, and get reset immediately. Then, the normal flow resumes, and they go to theBEGANas a result of touch input. To prevent that, I changedcleanupFinishedHandlersto be queued as a microtask instead of being executed immediately. This should ensure that it will be called in the same run loop, but after the gesture handles its state.Test plan
Tested on the following code: