Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvOS] Fix tvOS not building because of LongPressGestureHandler #3090

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[tvOS] Fix tvOS not building because of LongPressGestureHandler #3090

merged 2 commits into from
Sep 13, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Sep 5, 2024 •
edited
Loading

Description

When building a React Native app for TvOS, the following error is being thrown:
image

This PR fixes this issue by wrapping numberOfPointersRequired in a platform specific clause to fix the build error.

closes: #3089

Test plan

Try building TvOS before and after this change

@latekvo latekvo requested a review from j-piasecki September 5, 2024 10:53
@latekvo latekvo marked this pull request as ready for review September 5, 2024 10:53
@latekvo latekvo mentioned this pull request Sep 5, 2024
Closed
m-bert
m-bert approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please change handler name in the PR title to LongPressGestureHandler 😅

@latekvo latekvo changed the title [tvOS] Fix tvOS not building because of FlingGestureHandler [tvOS] Fix tvOS not building because of LongPressGestureHandler Sep 13, 2024
@latekvo latekvo changed the title [tvOS] Fix tvOS not building because of LongPressGestureHandler [tvOS] Fix tvOS not building because of LongPressGestureHandler Sep 13, 2024
@latekvo latekvo merged commit f6fcfc0 into main Sep 13, 2024
3 checks passed
@latekvo latekvo deleted the @latekvo/fix-tvos-not-building branch September 13, 2024 08:56
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

@j-piasecki j-piasecki Awaiting requested review from j-piasecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-native-tvOS not building
2 participants
@latekvo @m-bert