Sanitize ref name before uploading artifact #997
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
balins
force-pushed
the
jb/sanitize-artifact-name-when-packaging-extension
branch
from
2dbd7f2 to
9eab85e
Compare
kmagiera
reviewed
Feb 28, 2025
|
@kmagiera We will have possibly multiple builds per one version number, so I'd rather keep artifact names unique |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I didn't find any information in the docs, it seems that artifact names have some restrictions. This PR sanitizes the ref name before using it in artifact's name to avoid errors when packaging the extension from refs containing '', '/', "', ':', '<', '>', '|', '*', or '?' by replacing these characters with
-.