Repository navigation
refactor(android): reuse one flag for top-priority exclusive spans - #981
Merged
Merged
Conversation
Rename SPAN_FLAGS_CONTAINER_BACKGROUND to SPAN_FLAGS_EXCLUSIVE_EXCLUSIVE_PRIORITY and use it for HeadingSpan instead of the inline flag combination added in #938.
jnowakow
marked this pull request as ready for review
October 13, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
Follow-up to #938, addressing its review comments (1, 2).
#938 set
HeadingSpanwithSpanned.SPAN_EXCLUSIVE_EXCLUSIVE or Spanned.SPAN_PRIORITY, the same value asSPAN_FLAGS_CONTAINER_BACKGROUND. This PR renames that constant to the more genericSPAN_FLAGS_EXCLUSIVE_EXCLUSIVE_PRIORITYand uses it in both places.SpanFlags.kt: rename and generalize the doc comment. It now covers both uses: a block span that must not override its inline spans (heading) and a container background that must sit under inline pills (blockquote).HeadingRenderer.kt: use the constant.BlockquoteRenderer.kt: use the renamed constant. The blockquote-specific reason now lives in a comment at the call site.The changes go into both
react-native-enriched-markdownand the standaloneenriched-markdown-android. The flag values don't change, so rendering doesn't either.Testing
ktlintCheckandcompileDebugKotlinpass for:react-native-enriched-markdownand the standalone:uimodule.PR Checklist