Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CKC_OPENPGP, a vendor-defined extension that others can repl... #36

Merged
merged 2 commits into from
Feb 6, 2014
Merged

Support for CKC_OPENPGP, a vendor-defined extension that others can repl... #36

merged 2 commits into from
Feb 6, 2014

Conversation

vanrein
Copy link
Contributor

@vanrein vanrein commented Jan 13, 2014

...icate.

This permits creation of OpenPGP "certificates" as specified on:
http://openfortress.nl/doc/spec/pgp-in-pkcs11/

@vanrein
Support for CKC_OPENPGP, a vendor-defined extension that others can r…
413378c 
…eplicate.

This permits creation of OpenPGP "certificates" as specified on:
http://openfortress.nl/doc/spec/pgp-in-pkcs11/
@ghost ghost assigned bellgrim Jan 13, 2014
@jschlyter
Copy link
Contributor

Thanks Rick, I'll asked Rickard to review this code.

@bellgrim
Copy link
Contributor

I will review this later (end of January) when I get more time. This review requires a little bit more work since you need to cross reference with two specifications (pgp-in-pkcs11 and pkcs11).

@vanrein
Copy link
Contributor Author

vanrein commented Jan 15, 2014

Rickard,

I will review this later (end of January) when I get more time. This review requires a little bit more work since you need to cross reference with two specifications (pgp-in-pkcs11 and pkcs11).

Thank you for considering it. Will be waiting happily.

-Ric

@bellgrim
Copy link
Contributor

The pull request can be merged once the issue about the extra attribute has been resolved. The other changes looks ok and are according to specification.

@vanrein
Copy link
Contributor Author

vanrein commented Jan 29, 2014

The pull request has been updated with a 2nd commit, effecting what was requested by Rickard. It should now be ready for inclusion. Thanks!

bellgrim added a commit that referenced this pull request Feb 6, 2014
@bellgrim
Merge pull request #36 from arpa2/openpgp4jakob
c5566f4 
Support for CKC_OPENPGP, a vendor-defined extension that others can repl...
@bellgrim bellgrim merged commit c5566f4 into softhsm:master Feb 6, 2014
@vanrein vanrein deleted the openpgp4jakob branch February 6, 2014 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bellgrim bellgrim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanrein @jschlyter @bellgrim