upgrade zipkin server version to v2 (2.11.1) #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanchao-yang
requested changes
Aug 21, 2018
| zipkinSpanBuilder | ||
| .duration((sofaTracerSpan.getEndTime() - sofaTracerSpan.getStartTime()) * 1000); | ||
| //traceId | ||
| SofaTracerSpanContext sofaTracerSpanContext = sofaTracerSpan.getSofaTracerSpanContext(); | ||
|
|
||
| /** | ||
| * Changes: |
There was a problem hiding this comment.
这个注释不要删除了，保留吧，可以让大家知道我们的思考过程。
| @@ -238,7 +208,6 @@ public static long spanIdToLong(String spanId) { | |||
| * @return fnv hash code | |||
| */ | |||
| public static long FNV64HashCode(String data) { | |||
| //hash FNVHash64 : http://www.isthe.com/chongo/tech/comp/fnv/index.html#FNV-param | |||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.zipkin.reporter</groupId> | ||
| <groupId>io.zipkin.reporter2</groupId> |
…ment sofarpc demo to readme;
Pull Request Test Coverage Report for Build 102
💛 - Coveralls |
guanchao-yang
added a commit
to guanchao-yang/sofa-tracer
that referenced
this pull request
Aug 25, 2018
Upgrade zipkin server version to v2 (2.11.1) (sofastack#55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
use zipkin2 server to show reported data.
Result:
Fixes #23
If there is no issue then describe the changes introduced by this PR.