Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disruptor event clear #547

Closed
wants to merge 2 commits into from

Conversation

ZijieSong
Copy link
Contributor

@ZijieSong ZijieSong commented Oct 22, 2024

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

  • New Features
    • Updated version number for the parent artifact across multiple plugins and projects from 3.1.7 to 3.1.8, indicating enhancements and improvements.
  • Bug Fixes
    • Corrected a typographical error in the GPG plugin property for the main project.
  • Documentation
    • Introduced a new interface ObjectEvent with a clear() method to enhance event management.
  • Refactor
    • Updated existing classes to implement the new ObjectEvent interface, improving memory management and event lifecycle handling.

Copy link

coderabbitai bot commented Oct 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request primarily updates the version number of the parent artifact across multiple pom.xml files from 3.1.7 to 3.1.8. Additionally, it corrects a typographical error in the pom.xml of the main project, changing maven.gpg.pluign to maven.gpg.plugin. The changes are consistent across various plugins and modules, with no alterations to dependencies or project structure.

Changes

File Path Change Summary
pom.xml Version updated from 3.1.7 to 3.1.8, typo corrected from maven.gpg.pluign to maven.gpg.plugin
sofa-tracer-plugins/sofa-tracer-datasource-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-dubbo-2.6.x-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-dubbo-common-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-dubbo-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-flexible-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-httpclient-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-kafkamq-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-mongodb-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-okhttp-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-rabbitmq-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-redis-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-resttmplate-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-rocketmq-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-springmessage-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-springmvc-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-all/pom.xml Parent and project version updated from 3.1.7 to 3.1.8
tracer-core/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-core/src/main/java/com/alipay/common/tracer/core/appender/manager/AsyncCommonAppenderManager.java Added event.clear() in onEvent method.
tracer-core/src/main/java/com/alipay/common/tracer/core/appender/manager/AsyncCommonDigestAppenderManager.java Added event.clear() in onEvent method and improved error logging.
tracer-core/src/main/java/com/alipay/common/tracer/core/appender/manager/ObjectEvent.java New interface ObjectEvent with method clear().
tracer-core/src/main/java/com/alipay/common/tracer/core/appender/manager/SofaTracerSpanEvent.java Implemented ObjectEvent interface and added clear() method.
tracer-core/src/main/java/com/alipay/common/tracer/core/appender/manager/StringEvent.java Implemented ObjectEvent interface and added clear() method.
tracer-extensions/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-sofa-boot-starter/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-test/core-test/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-test/log4j-test/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-test/log4j2-test/pom.xml Parent version updated from 3.1.7 to 3.1.8
tracer-test/logback-test/pom.xml Parent version updated from 3.1.7 to 3.1.8

Possibly related PRs

  • Disruptor event clear #546: This PR updates the version number in the pom.xml file for the tracer-all-parent artifact, which is a direct continuation of the versioning changes seen in the main PR.

Suggested labels

bug

🐰 In the garden, we hop and play,
Versions change, come what may!
From three point one to three point eight,
Typo fixed, oh, isn’t it great?
With every leap, our code is bright,
Hopping forward, all feels right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ZijieSong ZijieSong closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant