Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ZipkinRestTemplateSender NAME. #282

Merged
merged 3 commits into from
Oct 10, 2019
Merged

fix ZipkinRestTemplateSender NAME. #282

merged 3 commits into from
Oct 10, 2019

Conversation

xzchaoo
Copy link
Contributor

@xzchaoo xzchaoo commented Sep 26, 2019

fix ZipkinRestTemplateSender NPE.
fix getZipkinEndpoint error.

fix getZipkinEndpoint error.
@sofastack-bot sofastack-bot bot changed the title fix ZipkinRestTemplateSender NPE. fix ZipkinRestTemplateSender NAME. Sep 26, 2019
@sofastack-bot
Copy link

sofastack-bot bot commented Sep 26, 2019

Hi @xzchaoo, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@glmapper glmapper added this to the 3.0.8 milestone Sep 30, 2019
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glmapper glmapper merged commit 6dd0698 into sofastack:3.x Oct 10, 2019
xzchaoo added a commit to xzchaoo/sofa-tracer that referenced this pull request Oct 31, 2019
 fix ZipkinRestTemplateSender NPE.
@xzchaoo xzchaoo mentioned this pull request Oct 31, 2019
glmapper pushed a commit that referenced this pull request Nov 6, 2019
fix ZipkinRestTemplateSender NPE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants