Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix directUrl transform exception #1361

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix directUrl transform exception #1361

merged 2 commits into from
Aug 28, 2023

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Aug 28, 2023

modify directUrl transform exception

@EvenLjj EvenLjj changed the title modify directUrl transform exception fix directUrl transform exception Aug 28, 2023
@sofastack-cla sofastack-cla bot added the bug Something isn't working label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #1361 (ea28f74) into master (666261d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1361      +/-   ##
============================================
+ Coverage     72.03%   72.05%   +0.02%     
  Complexity      784      784              
============================================
  Files           416      416              
  Lines         17661    17661              
  Branches       2752     2752              
============================================
+ Hits          12722    12726       +4     
+ Misses         3537     3531       -6     
- Partials       1402     1404       +2
Files Changed Coverage Δ
...alipay/sofa/rpc/registry/local/DomainRegistry.java 94.26% <100.00%> (ø)

... and 3 files with indirect coverage changes

chuailiwu
chuailiwu approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lo1nt Lo1nt merged commit bff853f into master Aug 28, 2023
leslieSll
leslieSll reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@leslieSll leslieSll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam deleted the fix/direct_url_transform branch August 31, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslieSll leslieSll leslieSll left review comments

@chuailiwu chuailiwu chuailiwu approved these changes

@Lo1nt Lo1nt Lo1nt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes CLA is ok size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EvenLjj @chuailiwu @Lo1nt @leslieSll