Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1,修复gson版本导致的漏洞 #1358

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

xuqiu
Copy link
Member

@xuqiu xuqiu commented Aug 8, 2023

修复由小程序云代码扫描报出的漏洞:
危害等级:高危
漏洞类型:反序列化漏洞
漏洞子类型:MPS-2022-12287_com.google.code.gson_gson
漏洞编号:
MPS-2022-12287
CVE-2022-25647
漏洞状态: 漏洞提交
首次发现时间:2023-07-21 13:39:52
最近发现时间:2023-08-08 16:02:39
漏洞基因编码:b953014247a1a4716f6d56e1f7e51ad3
漏洞源文件:https://github.com/sofastack/sofa-rpc/blob/master/config/config-apollo/pom.xml
详细内容:
{
间接依赖的组件是:
com.google.code.gson
[H[gson]H]

间接依赖链路如下:
com.ctrip.framework.apollo:apollo-client:1.4.0->com.google.code.gson:gson:2.8.0

对应的修复版本为:
2.8.9
}

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/S labels Aug 8, 2023
@xuqiu xuqiu force-pushed the fix-gson-version branch from bb143de to 71c2267 Compare August 8, 2023 08:28
@sofastack-cla sofastack-cla bot added size/XS and removed size/S labels Aug 8, 2023
Copy link
Collaborator

@Lo1nt Lo1nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls specify

Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:
Describe the idea and modifications you've done.

Result:
Fixes #.

If there is no issue then describe the changes introduced by this PR.

@nobodyiam
Copy link
Member

It may be advisable to upgrade apollo-client to version 2.1.0, as the transitive gson version has been updated to 2.8.9 since the release of version 2.0.1. However, it's important to note that, beginning with the 2.0.0 release, apollo-client has ceased support for Java 1.7, constituting a significant change.

@xuqiu
Copy link
Member Author

xuqiu commented Aug 10, 2023

got it, working on it

@xuqiu xuqiu force-pushed the fix-gson-version branch from 71c2267 to ac5ed03 Compare August 10, 2023 02:22
@xuqiu
Copy link
Member Author

xuqiu commented Aug 10, 2023

upgraded apollo-client to version 2.1.0, gson gone up to 2.8.9 as well.

@EvenLjj EvenLjj closed this Oct 3, 2023
@EvenLjj EvenLjj reopened this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e7f751) 72.07% compared to head (ac5ed03) 72.00%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1358      +/-   ##
============================================
- Coverage     72.07%   72.00%   -0.08%     
+ Complexity      784      783       -1     
============================================
  Files           416      416              
  Lines         17661    17661              
  Branches       2752     2752              
============================================
- Hits          12730    12717      -13     
- Misses         3526     3539      +13     
  Partials       1405     1405              

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt merged commit 2219a4b into sofastack:master Jan 8, 2024
@Lo1nt Lo1nt added this to the 5.12.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants