Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of triple header losing information #1289

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Dec 29, 2022

Fix the problem of triple header losing information

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/M labels Dec 29, 2022
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #1289 (da9a41b) into master (1e386ed) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1289      +/-   ##
============================================
+ Coverage     72.01%   72.06%   +0.05%     
- Complexity      783      784       +1     
============================================
  Files           414      414              
  Lines         17565    17568       +3     
  Branches       2740     2741       +1     
============================================
+ Hits          12650    12661      +11     
+ Misses         3521     3516       -5     
+ Partials       1394     1391       -3     
Impacted Files Coverage Δ
...ofa/rpc/tracer/sofatracer/TripleTracerAdapter.java 63.57% <66.66%> (+2.25%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <0.00%> (-1.07%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 71.54% <0.00%> (+0.26%) ⬆️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) ⬆️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (+1.58%) ⬆️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 84.00% <0.00%> (+4.00%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 72.46% <0.00%> (+7.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@EvenLjj EvenLjj added this to the 5.9.1 milestone Jan 3, 2023
Copy link
Collaborator

@leslieSll leslieSll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 7809a25 into sofastack:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants